Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwrap from public_key() function #256

Closed
kevinlewi opened this issue Jan 3, 2022 · 1 comment · Fixed by #261
Closed

Remove unwrap from public_key() function #256

kevinlewi opened this issue Jan 3, 2022 · 1 comment · Fixed by #261

Comments

@kevinlewi
Copy link
Contributor

These unwraps have to be removed.

My idea was to use the appropriate SecretKey type instead of storing GenericArrays everywhere. I believe this would be better anyway, because conversion isn't free (it's very cheap though) and any checking is now guaranteed in the type and can now be handled during serialization and creation.

Originally posted by @daxpedda in #250 (comment)

@daxpedda
Copy link
Contributor

daxpedda commented Jan 4, 2022

RustCrypto/utils#652 is a problem we will have to circumvent if we want to use these types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants