-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es5 build of pretty-format #4075
Conversation
Seems like this fails CI? |
Thank you for following up. Was about to try, but better for me to watch and learn :) |
876ddd6
to
e19d0b0
Compare
@@ -155,4 +155,4 @@ const print = ( | |||
return result; | |||
}; | |||
|
|||
module.exports = ({print, test}: Plugin); | |||
export default ({print, test}: Plugin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding both the default and named export we support both ES6 module consumers (like rollup) and CommonJS require
use several places in Jest source code.
@cpojer hopefully CI should be happy again now. |
e19d0b0
to
ab7feb0
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #4002
Test plan
I've added a simple integration tests.