Ignore order on unordered Immutable.js structures, fixes #4618 #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinpokorny
commented
Feb 9, 2018
| .set(1, 'one'), | ||
| ], | ||
| [ | ||
| Immutable.Map({1: Immutable.Map({2: {a: 99}})}), |
There was a problem hiding this comment.
This is to show that deep equality works.
robinpokorny
commented
Feb 9, 2018
| .set(2, 'two'), | ||
| ], | ||
| [ | ||
| Immutable.Map({1: Immutable.Map({2: {a: 99}})}), |
There was a problem hiding this comment.
This is to show that deep equality works.
robinpokorny
force-pushed
the
ignore-order-on-unordered-immutable
branch
2 times, most recently
from
8e161ac to
5a0a42c
Compare
robinpokorny
force-pushed
the
ignore-order-on-unordered-immutable
branch
from
5a0a42c to
bc2ff08
Compare
|
The CI fails during restoring cache because ‘Permission denied’. Does anybody know why this happens? |
|
Thanks Robin! This looks good, I merged it but will monitor CI to see if it fails. This sometimes happens when a CI run is interrupted, pretty weird. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Immutable.js structures, that do not maintain order, should be equal regardless of the insertion order. This follows how native
SetandMapare compared.As
toEqualshould provide deep equality,Immutable.is(or.equalson a structure) cannot be used.Sentinels are used for identifying the structures, as we do in pretty-format.
Fixes #4618 (includes additional info and reasons)
Test plan
Added most used Immutable.js structures to unit tests:
List,Map,OrdereMap,Set,OrderedSet.