Mock date/time functions in Isolation.php

Summary: Mock date/time functions (e.g. time() ) so they never return the same value when calling multiple times.
By doing so, more flakey test cases can be found.

Closes #4384

Reviewed By: @JoelMarcey

Differential Revision: D1719095

Signature: t1:1719095:1418338273:e3867d429e3162f1110e96b1c16677da5872d8c0

Author: RyanCccc

hphp/test/frameworks/Isolation.php

@@ -134,6 +134,91 @@ function tempnam_ISOLATION_WRAPPER() {
 fb_rename_function('tempnam', 'ORIG_tempnam');
 fb_rename_function('tempnam_ISOLATION_WRAPPER', 'tempnam');
 
+function time_ISOLATION_WRAPPER() {
+  static $time;
+  $org_time = ORIG_time();
+  if ($time === null) {
+    $time = $org_time;
+    return $time;
+  }
+  if ($time >= $org_time) {
+    ++$time;
+  } else {
+    $time = $org_time;
+  }
+  return $time;
+}
+fb_rename_function('time', 'ORIG_time');
+fb_rename_function('time_ISOLATION_WRAPPER', 'time');
+
+function microtime_ISOLATION_WRAPPER(bool $get_as_float = false) {
+  static $time;
+  list($msec, $sec) = explode(" ", ORIG_microtime());
+  if ($time === null) {
+    $time = $sec;
+  } else if ($time >= $sec){
+    ++$time;
+  } else {
+    $time = $sec;
+  }
+  if ($get_as_float)
+    return ((float)$msec + (float)$time);
+  else
+    return "{$msec} {$time}";
+}
+fb_rename_function('microtime', 'ORIG_microtime');
+fb_rename_function('microtime_ISOLATION_WRAPPER', 'microtime');
+
+function date_ISOLATION_WRAPPER(?string $format, ?int $timestamp = null) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_date($format, $timestamp);
+}
+fb_rename_function('date', 'ORIG_date');
+fb_rename_function('date_ISOLATION_WRAPPER', 'date');
+
+function gmdate_ISOLATION_WRAPPER(?string $format, ?int $timestamp = null) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_gmdate($format, $timestamp);
+}
+fb_rename_function('gmdate', 'ORIG_gmdate');
+fb_rename_function('gmdate_ISOLATION_WRAPPER', 'gmdate');
+
+function strftime_ISOLATION_WRAPPER(?string $format, ?int $timestamp = null) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_strftime($format, $timestamp);
+}
+fb_rename_function('strftime', 'ORIG_strftime');
+fb_rename_function('strftime_ISOLATION_WRAPPER', 'strftime');
+
+function strtotime_ISOLATION_WRAPPER(?string $time, ?int $now = null) {
+  $now = ($now === null ? time() : $now);
+  return ORIG_strtotime($time, $now);
+}
+fb_rename_function('strtotime', 'ORIG_strtotime');
+fb_rename_function('strtotime_ISOLATION_WRAPPER', 'strtotime');
+
+function idate_ISOLATION_WRAPPER(?string $format, ?int $timestamp = null) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_idate($format, $timestamp);
+}
+fb_rename_function('idate', 'ORIG_idate');
+fb_rename_function('idate_ISOLATION_WRAPPER', 'idate');
+
+function getdate_ISOLATION_WRAPPER(?int $timestamp = null) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_getdate($timestamp);
+}
+fb_rename_function('getdate', 'ORIG_getdate');
+fb_rename_function('getdate_ISOLATION_WRAPPER', 'getdate');
+
+function localtime_ISOLATION_WRAPPER(?int $timestamp = null, bool $is_associative = false) {
+  $timestamp = ($timestamp === null ? time() : $timestamp);
+  return ORIG_localtime($timestamp, $is_associative);
+}
+fb_rename_function('localtime', 'ORIG_localtime');
+fb_rename_function('localtime_ISOLATION_WRAPPER', 'localtime');
+
+
 //////////////////////
 // Files - Checking //
 //////////////////////

hphp/test/frameworks/frameworks.yaml

@@ -71,6 +71,9 @@
       # Assumes that calculating the current time in seconds twice will give
       # the same result. Not true if you're unlucky.
       - codeigniter/tests/codeigniter/helpers/date_helper_test.php
+      # Flakey test case. Already made a PR 
+      # at https://github.com/bcit-ci/CodeIgniter/pull/3399.
+      - codeigniter/tests/codeigniter/libraries/Session_test.php
   composer:
     url: https://github.com/composer/composer.git
     # master is the only available branch
@@ -523,6 +526,10 @@
       - phpbb3/tests/lock/flock_test.php
       # race condition - https://github.com/phpbb/phpbb/pull/3006
       - phpbb3/tests/wrapper/gmgetdate_test.php
+      # This flakey test is caused by assuming time functions always return the
+      # same value. Made PR https://github.com/phpbb/phpbb/pull/3222 to fix.
+      - phpbb3/tests/passwords/manager_test.php
+      - phpbb3/tests/random/gen_rand_string_test.php
   phpmyadmin:
     url: https://github.com/phpmyadmin/phpmyadmin.git
     # Stable is RELEASE_4_1_9 but we have many pull requests in master