From 13402c3cafe1e6422eebd4582ea1e0e2eeb75b18 Mon Sep 17 00:00:00 2001
From: Caleb Marchent <cmarchent@fb.com>
Date: Tue, 15 Jan 2019 15:55:59 +0000
Subject: [PATCH] Try to "make" the python extension during compile

---
 folly/CMakeLists.txt | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/folly/CMakeLists.txt b/folly/CMakeLists.txt
index 647d697bef3..93f758274ce 100644
--- a/folly/CMakeLists.txt
+++ b/folly/CMakeLists.txt
@@ -14,8 +14,7 @@ install(
 
 add_subdirectory(experimental/exception_tracer)
 
-get_target_property(pic folly POSITION_INDEPENDENT_CODE)
-if (pic AND CYTHON_FOUND AND PYTHONINTERP_FOUND)
+if (CYTHON_FOUND AND PYTHONINTERP_FOUND)
   # Create tree of symbolic links in structure required for successful
   # compliation by Cython.
   #   - must be in path named same as extension
@@ -34,10 +33,14 @@ if (pic AND CYTHON_FOUND AND PYTHONINTERP_FOUND)
     COMMAND ${CMAKE_COMMAND} -E create_symlink ${CMAKE_CURRENT_SOURCE_DIR}/python/${_src} "${_cybld}/folly/${_src}")
   endforeach()
 
+  add_custom_target(folly_python_bindings ALL
+    COMMAND python3 ${CMAKE_CURRENT_SOURCE_DIR}/setup.py build_ext -f
+    WORKING_DIRECTORY ${_cybld})
+
   # Install Folly Python Bindings
   install(CODE "
     string(REGEX REPLACE \"^(..*)$\" \"--root=\\\\1\" PYROOT \"\$ENV{DESTDIR}\")
     execute_process(COMMAND
-    python3 ${CMAKE_CURRENT_SOURCE_DIR}/setup.py build_ext -f install \${PYROOT}
+    python3 ${CMAKE_CURRENT_SOURCE_DIR}/setup.py install \${PYROOT}
     WORKING_DIRECTORY ${_cybld})")
 endif ()