we find a memory leak in fishhook function "prepend_rebindings",line 67

[rosen0510]

new_entry->rebindings = (struct rebinding *) malloc(sizeof(struct rebinding) * nel);
This malloc region didn't free in appropriate position

[dinhvh]

In fishhook, entries are not removed.
Then, we keep them in memory forever.

[rosen0510]

The "new_enry->rebindings" can't be accessed in anywhere after that function, why don't you free it ? It's there any special reason ?

[dinhvh]

It can be accessed via new_entry.

[rosen0510]

But in function "rebind_symbos_image" ,line 190, you freed the "rebinds_head" which is the same as "new_entry".

[dinhvh]

Could you send a pull request to solve it then?

[rosen0510]

ok

[megCanicalKb]

06cfb58