This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Force update of fbjs to get fix for #14, #1381
#1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hive#1381 **what is the change?:** Pin the `fbjs` dependency version to 0.8.15 or later. **why make this change?:** We need to get everyone updated to use the fixed version, to avoid a scroll issue in Chrome 61+ **test plan:** Didn't test because we already are using this fix internally at FB. **issue:** fixes facebookarchive#1381
flarnie
force-pushed
the
getScrollFixByUpdatingFbjs
branch
from
c07892e to
b888079
Compare
sophiebits
suggested changes
Sep 22, 2017
|
(If people re-npm-install they'll get the new version already.) |
|
Sure thing~ |
sophiebits
approved these changes
Sep 22, 2017
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: **what is the change?:** Pin the `fbjs` dependency version to 0.8.15 or later. **why make this change?:** We need to get everyone updated to use the fixed version, to avoid a scroll issue in Chrome 61+ See facebook/fbjs#229 **test plan:** Didn't test because we already are using this fix internally at FB. **issue:** fixes #1381 Closes facebookarchive/draft-js#1401 Differential Revision: D5892624 fbshipit-source-id: 6839e647b6ba0fb99d6ec118748cdeac808cbcdb
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **what is the change?:** Pin the `fbjs` dependency version to 0.8.15 or later. **why make this change?:** We need to get everyone updated to use the fixed version, to avoid a scroll issue in Chrome 61+ See facebook/fbjs#229 **test plan:** Didn't test because we already are using this fix internally at FB. **issue:** fixes #1381 Closes facebookarchive/draft-js#1401 Differential Revision: D5892624 fbshipit-source-id: 6839e647b6ba0fb99d6ec118748cdeac808cbcdb
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **what is the change?:** Pin the `fbjs` dependency version to 0.8.15 or later. **why make this change?:** We need to get everyone updated to use the fixed version, to avoid a scroll issue in Chrome 61+ See facebook/fbjs#229 **test plan:** Didn't test because we already are using this fix internally at FB. **issue:** fixes #1381 Closes facebookarchive/draft-js#1401 Differential Revision: D5892624 fbshipit-source-id: 6839e647b6ba0fb99d6ec118748cdeac808cbcdb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
Pin the
fbjsdependency version to 0.8.15 or later.why make this change?:
We need to get everyone updated to use the fixed version, to avoid a
scroll issue in Chrome 61+
See facebook/fbjs#229
test plan:
Didn't test because we already are using this fix internally at FB.
issue:
fixes #1381