Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to feeds became detected as broken in 3.1.0 #9813

Closed
4 of 7 tasks
Zwyx opened this issue Feb 1, 2024 · 3 comments
Closed
4 of 7 tasks

Links to feeds became detected as broken in 3.1.0 #9813

Zwyx opened this issue Feb 1, 2024 · 3 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: working as intended This issue is intended behavior, there's no need to take any action.

Comments

@Zwyx
Copy link
Contributor

Zwyx commented Feb 1, 2024

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

My blog's home page contains links to the feed files:

[rss](/blog/rss.xml)   [atom](/blog/atom.xml)   [json](/blog/feed.json)

image

Until Docusaurus 3.0.0, the site was built successfully, but starting in 3.1.0, this error happens:

  [cause]: Error: Docusaurus found broken links!
 
  Exhaustive list of all broken links found:
  - Broken link on source page path = /:
     -> linking to /blog/rss.xml
     -> linking to /blog/atom.xml
     -> linking to /blog/feed.json

Reproducible demo

https://github.com/Zwyx/zwyx.dev

Steps to reproduce

In https://github.com/Zwyx/zwyx.dev, the branch main builds correctly, the branch update-docusaurus doesn't.

Expected behavior

Links to feed files shouldn't be detected as broken.

Actual behavior

Links to feed files are detected as broken.

Your environment

  • Public source code: https://github.com/Zwyx/zwyx.dev
  • Public site URL: https://zwyx.dev
  • Docusaurus version used: live site: 3.0.0, update-docusaurus branch: 3.1.1
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): N/A
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): N/A

Self-service

  • I'd be willing to fix this bug myself.
@Zwyx Zwyx added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Feb 1, 2024
@slorber
Copy link
Collaborator

slorber commented Feb 1, 2024

This is the same problem as the one described here: #9803

You do have broken links if you click on the RSS feed link (without middle click, do not open the feed in new tabs)

CleanShot 2024-02-01 at 15 11 43

You should use the pathname:// protocol to link to any page or resource that is not an SPA route known by Docusaurus. Otherwise it won't work when navigating that link.

See my answer here in particular: #9803 (comment)

@slorber slorber closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
@slorber slorber added closed: working as intended This issue is intended behavior, there's no need to take any action. and removed status: needs triage This issue has not been triaged by maintainers labels Feb 1, 2024
@Zwyx
Copy link
Contributor Author

Zwyx commented Feb 3, 2024

I can't believe I never noticed these links were broken 🤦 I've always middle-clicked them...

Thank you very much and apologises for this silly mistake.

@slorber
Copy link
Collaborator

slorber commented Feb 3, 2024

That's our fault, we should have told you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: working as intended This issue is intended behavior, there's no need to take any action.
Projects
None yet
Development

No branches or pull requests

2 participants