Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<html> element does not have a [lang] attribute #2471

Closed
gedenata opened this issue Mar 27, 2020 · 2 comments
Closed

<html> element does not have a [lang] attribute #2471

gedenata opened this issue Mar 27, 2020 · 2 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution help wanted Asking for outside help and/or contributions to this particular issue or PR. v1 This issue is for Docusaurus 1

Comments

@gedenata
Copy link

gedenata commented Mar 27, 2020 •
edited
Loading

🐛 Bug Report

If a page doesn't specify a lang attribute, a screen reader assumes that the page is in the default language that the user chose when setting up the screen reader. If the page isn't actually in the default language, then the screen reader might not announce the page's text correctly.

Have you read the Contributing Guidelines on issues?

yes.

To Reproduce

  • When deploy the index.html to server there is no lang attribute, or
  • View Page Source the website <!DOCTYPE html><html lang=""><head><meta charSet="utf-8" /><meta http-equiv="X-UA-Compatible" content="IE=edge" />

Expected behavior

Your Environment

  • Docusaurus version used: "docusaurus": "^1.14.4"
  • Google Chrome Version 80.0.3987.149 (Official Build) (64-bit)
  • macOS Mojave V.10.14.6
@gedenata gedenata added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Mar 27, 2020
@yangshun yangshun added help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Mar 27, 2020
@lex111 lex111 added the v1 This issue is for Docusaurus 1 label Mar 27, 2020
@yangshun yangshun mentioned this issue Jun 5, 2020
Closed
@slorber slorber mentioned this issue Aug 21, 2020
Closed
@slorber
Copy link
Collaborator

slorber commented Aug 21, 2020

will be fixed in v2 i18n: #3317

@slorber
Copy link
Collaborator

slorber commented Jun 10, 2021

The Docusaurus team is actively working on Docusaurus v2.

After a very long alpha, Docusaurus v2 is now in beta.
We believe that the v2 beta is already better than v1, and v2 is ready for maintstream adoption.

Apart from critical issues and security fixes, we don't plan to invest much time on Docusaurus v1 anymore.

We are all closing v1 issues.
Maybe the current issue is already fixed in Docusaurus v2.
Please try to upgrade, and if the issue is still there on Docusaurus v2, open a new issue.

@slorber slorber closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution help wanted Asking for outside help and/or contributions to this particular issue or PR. v1 This issue is for Docusaurus 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slorber @gedenata @yangshun @lex111