Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to other documents in markdown files not resolved to html when versioning is enabled #1271

Closed
parthpp opened this issue Mar 8, 2019 · 2 comments

Comments

@parthpp
Copy link
Contributor

parthpp commented Mar 8, 2019

🐛 Bug Report

Links from one document in docs to the document in docs that are written in markdown syntax are not converted to html links when versioning is enabled.

Please refer to the following project and follow its readme to reproduce the bug : https://github.com/parthpp/Docusaurus-Broken-Links

Have you read the Contributing Guidelines on issues?

Yes

Reproducible Demo

Please clone the following repository and follow the steps mentioned in its read me file to reproduce the bug : https://github.com/parthpp/Docusaurus-Broken-Links

@parthpp
Copy link
Contributor Author

parthpp commented Mar 8, 2019

I think the problem is due to the metadata.mdToHtml file returning prematurely when the metadata has metadata.original_id. Since all the versioned documents will have metadata.original_id, but since the method returns prematurely mdToHtml will not have links from md to html for these versioned documents.
CC: @yangshun @endiliey

@endiliey
Copy link
Contributor

Seems to be relative path problem on v1. This issue won't happen on v2.

Easy workaround for your case now is to do it like this: (Refer it with the subdirectory)

Please refer to [consumption](api/consumption.md).  

Fix is coming on #1281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants