From 240fa113d9d73eb44259921e641f819368dccb53 Mon Sep 17 00:00:00 2001
From: Sathish <sathishwelcomez@ymail.com>
Date: Sun, 30 Oct 2016 22:15:23 +0530
Subject: [PATCH 1/2] Clears the usage of react-jsx-source & react-jsx-self
---
packages/babel-preset-react-app/index.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js
index d6e9c4519d4..3ce269dbcaa 100644
--- a/packages/babel-preset-react-app/index.js
+++ b/packages/babel-preset-react-app/index.js
@@ -54,6 +54,12 @@ if (env !== 'development' && env !== 'test' && env !== 'production') {
}
if (env === 'development' || env === 'test') {
+ // The following two plugins are currently necessary to make jsx developer
+ // friendly messages, if you wondering why it is added here seprately rather
+ // it comes with babel-preset-react see the below threads for more info
+ // https://github.com/babel/babel/issues/4702
+ // https://github.com/babel/babel/pull/3540#issuecomment-228673661
+ // https://github.com/facebookincubator/create-react-app/issues/989
plugins.push.apply(plugins, [
// Adds component stack to warning messages
require.resolve('babel-plugin-transform-react-jsx-source'),
@@ -99,4 +105,3 @@ if (env === 'test') {
// ]);
}
}
-
From 562e8fbcabf962d0955747de63b3f3361c723bc3 Mon Sep 17 00:00:00 2001
From: Dan Abramov <dan.abramov@gmail.com>
Date: Thu, 17 Nov 2016 12:53:34 +0000
Subject: [PATCH 2/2] Tweak wording
---
packages/babel-preset-react-app/index.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js
index 3ce269dbcaa..dea2ceee700 100644
--- a/packages/babel-preset-react-app/index.js
+++ b/packages/babel-preset-react-app/index.js
@@ -54,9 +54,9 @@ if (env !== 'development' && env !== 'test' && env !== 'production') {
}
if (env === 'development' || env === 'test') {
- // The following two plugins are currently necessary to make jsx developer
- // friendly messages, if you wondering why it is added here seprately rather
- // it comes with babel-preset-react see the below threads for more info
+ // The following two plugins are currently necessary to make React warnings
+ // include more valuable information. They are included here because they are
+ // currently not enabled in babel-preset-react. See the below threads for more info:
// https://github.com/babel/babel/issues/4702
// https://github.com/babel/babel/pull/3540#issuecomment-228673661
// https://github.com/facebookincubator/create-react-app/issues/989