From a1cb97762401309c57110135d629e6ce8e8f77e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Martin?= Date: Tue, 27 Oct 2020 02:25:45 +0100 Subject: [PATCH 1/2] fix: fast refresh is enabled if `FAST_REFRESH` environment variable is not set --- packages/react-scripts/config/env.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js index 0ad47cb9779..c3c97c37753 100644 --- a/packages/react-scripts/config/env.js +++ b/packages/react-scripts/config/env.js @@ -97,7 +97,7 @@ function getClientEnvironment(publicUrl) { // react-refresh is not 100% stable at this time, // which is why it's disabled by default. // It is defined here so it is available in the webpackHotDevClient. - FAST_REFRESH: process.env.FAST_REFRESH !== 'false', + FAST_REFRESH: process.env.FAST_REFRESH && process.env.FAST_REFRESH !== 'false', } ); // Stringify all values so we can feed into webpack DefinePlugin From fef49191a3747190335936e2f3dea4825ee0c8f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Martin?= Date: Tue, 27 Oct 2020 10:26:28 +0100 Subject: [PATCH 2/2] fix: adjust comment to match implementation --- packages/react-scripts/config/env.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js index c3c97c37753..307d973de7e 100644 --- a/packages/react-scripts/config/env.js +++ b/packages/react-scripts/config/env.js @@ -93,11 +93,10 @@ function getClientEnvironment(publicUrl) { WDS_SOCKET_HOST: process.env.WDS_SOCKET_HOST, WDS_SOCKET_PATH: process.env.WDS_SOCKET_PATH, WDS_SOCKET_PORT: process.env.WDS_SOCKET_PORT, - // Whether or not react-refresh is enabled. - // react-refresh is not 100% stable at this time, - // which is why it's disabled by default. + // react-refresh is enabled by default. + // It can be disabled by setting `FAST_REFRESH` to `false`. // It is defined here so it is available in the webpackHotDevClient. - FAST_REFRESH: process.env.FAST_REFRESH && process.env.FAST_REFRESH !== 'false', + FAST_REFRESH: process.env.FAST_REFRESH !== 'false', } ); // Stringify all values so we can feed into webpack DefinePlugin