Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling Yarn integration #1390

Closed
gaearon opened this issue Jan 13, 2017 · 3 comments
Closed

Consider disabling Yarn integration #1390

gaearon opened this issue Jan 13, 2017 · 3 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 13, 2017

I've seen quite a few reports like this: https://twitter.com/schep_/status/819642790137200641. We need to figure out if it's Yarn bug causing it or not.

If it is caused Yarn we should disable the integration until it's more stable. This leaves a bad impression on React.

@dschep
Copy link
Contributor

dschep commented Jan 13, 2017

It indeed was the yarn integration. Tho still not as small as you're expecting it to be.

$ rm -rf node_modules && npm install && du -sh node_modules
274M node_modules/

@gaearon
Copy link
Contributor Author

gaearon commented Jan 13, 2017

Will need to investigate, thanks.
Probably some dependencies have updated their dependencies and resulted in duplicate near identical trees.

@gaearon
Copy link
Contributor Author

gaearon commented Feb 11, 2017

The size issue was worked around in 0.9.0 so closing this.
🎊

@gaearon gaearon closed this as completed Feb 11, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants