From da1d534a6b25128f4e96da2c741041c3e220f89a Mon Sep 17 00:00:00 2001 From: Vesa Laakso Date: Thu, 17 Nov 2016 14:48:22 +0200 Subject: [PATCH 1/2] Update babel-present-env and use node: 'current' as target (#1051) * Update babel-preset-env to 0.0.8 Changes between 0.0.6 and 0.0.8 should be backwards compatible: https://github.com/babel/babel-preset-env/blob/master/CHANGELOG.md * Use `node: 'current'` as target for babel-preset-env This replaces the hand-rolled node version setup with a new feature that was introduced in babel-preset-env@v0.0.7 https://github.com/babel/babel-preset-env/blob/v0.0.7/CHANGELOG.md --- packages/babel-preset-react-app/index.js | 2 +- packages/babel-preset-react-app/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js index d6e9c4519d4..7af36414246 100644 --- a/packages/babel-preset-react-app/index.js +++ b/packages/babel-preset-react-app/index.js @@ -68,7 +68,7 @@ if (env === 'test') { // ES features necessary for user's Node version [require('babel-preset-env').default, { targets: { - node: parseFloat(process.versions.node), + node: 'current', }, }], // JSX, Flow diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index bba2df1e0b1..6ddae417bc2 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -20,7 +20,7 @@ "babel-plugin-transform-react-jsx-source": "6.9.0", "babel-plugin-transform-regenerator": "6.16.1", "babel-plugin-transform-runtime": "6.15.0", - "babel-preset-env": "0.0.6", + "babel-preset-env": "0.0.8", "babel-preset-latest": "6.16.0", "babel-preset-react": "6.16.0", "babel-runtime": "6.11.6" From 80fe767bf253227a4633c8ec3242f8ac3d90b566 Mon Sep 17 00:00:00 2001 From: Sathish Date: Thu, 17 Nov 2016 18:24:12 +0530 Subject: [PATCH 2/2] Clears the usage of react-jsx-source & react-jsx-self (#992) Explain the usage of react-jsx-source & react-jsx-self --- packages/babel-preset-react-app/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js index 7af36414246..2aa1641ce35 100644 --- a/packages/babel-preset-react-app/index.js +++ b/packages/babel-preset-react-app/index.js @@ -54,6 +54,12 @@ if (env !== 'development' && env !== 'test' && env !== 'production') { } if (env === 'development' || env === 'test') { + // The following two plugins are currently necessary to make React warnings + // include more valuable information. They are included here because they are + // currently not enabled in babel-preset-react. See the below threads for more info: + // https://github.com/babel/babel/issues/4702 + // https://github.com/babel/babel/pull/3540#issuecomment-228673661 + // https://github.com/facebookincubator/create-react-app/issues/989 plugins.push.apply(plugins, [ // Adds component stack to warning messages require.resolve('babel-plugin-transform-react-jsx-source'), @@ -99,4 +105,3 @@ if (env === 'test') { // ]); } } -