From 3c2f2d4b1f2726cc810b443044b5a65b225cd5ca Mon Sep 17 00:00:00 2001 From: Shakib Hossain <3992124+shakib609@users.noreply.github.com> Date: Mon, 4 May 2020 09:34:55 +0600 Subject: [PATCH] Add import/no-anonymous-default-export lint rule (#8926) --- packages/eslint-config-react-app/index.js | 1 + .../fixtures/kitchensink/template/src/absoluteLoad.js | 4 +++- .../kitchensink/template/src/features/config/BaseUrl.js | 2 +- .../template/src/features/env/ExpandEnvVariables.js | 4 +++- .../template/src/features/env/FileEnvVariables.js | 4 +++- .../kitchensink/template/src/features/env/PublicUrl.js | 4 +++- .../template/src/features/env/ShellEnvVariables.js | 4 +++- .../template/src/features/syntax/ArrayDestructuring.js | 2 +- .../kitchensink/template/src/features/syntax/ArraySpread.js | 2 +- .../kitchensink/template/src/features/syntax/AsyncAwait.js | 2 +- .../template/src/features/syntax/ClassProperties.js | 2 +- .../template/src/features/syntax/ComputedProperties.js | 2 +- .../template/src/features/syntax/CustomInterpolation.js | 2 +- .../template/src/features/syntax/DefaultParameters.js | 2 +- .../template/src/features/syntax/DestructuringAndAwait.js | 2 +- .../kitchensink/template/src/features/syntax/Generators.js | 2 +- .../template/src/features/syntax/NullishCoalescing.js | 2 +- .../template/src/features/syntax/ObjectDestructuring.js | 2 +- .../template/src/features/syntax/ObjectSpread.js | 2 +- .../template/src/features/syntax/OptionalChaining.js | 2 +- .../kitchensink/template/src/features/syntax/Promises.js | 2 +- .../template/src/features/syntax/RestAndDefault.js | 2 +- .../template/src/features/syntax/RestParameters.js | 2 +- .../template/src/features/syntax/TemplateInterpolation.js | 2 +- .../template/src/features/webpack/CssInclusion.js | 6 +++++- .../template/src/features/webpack/CssModulesInclusion.js | 4 +++- .../template/src/features/webpack/DynamicImport.js | 4 +++- .../template/src/features/webpack/ImageInclusion.js | 4 +++- .../template/src/features/webpack/JsonInclusion.js | 6 +++++- .../template/src/features/webpack/LinkedModules.js | 4 +++- .../template/src/features/webpack/NoExtInclusion.js | 4 +++- .../template/src/features/webpack/SassInclusion.js | 6 +++++- .../template/src/features/webpack/SassModulesInclusion.js | 4 +++- .../template/src/features/webpack/ScssInclusion.js | 6 +++++- .../template/src/features/webpack/ScssModulesInclusion.js | 4 +++- .../template/src/features/webpack/SvgComponent.js | 4 +++- .../kitchensink/template/src/features/webpack/SvgInCss.js | 4 +++- .../template/src/features/webpack/SvgInclusion.js | 6 +++++- .../template/src/features/webpack/UnknownExtInclusion.js | 4 +++- test/fixtures/node_path/src/App.js | 2 +- test/fixtures/node_path/src/absoluteLoad.js | 4 +++- 41 files changed, 93 insertions(+), 40 deletions(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 0d29e7995a6..5e5825e99ef 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -253,6 +253,7 @@ module.exports = { // https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules 'import/first': 'error', 'import/no-amd': 'error', + 'import/no-anonymous-default-export': 'warn', 'import/no-webpack-loader-syntax': 'error', // https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/absoluteLoad.js b/packages/react-scripts/fixtures/kitchensink/template/src/absoluteLoad.js index 5c4f7842e28..72da1c69042 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/absoluteLoad.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/absoluteLoad.js @@ -5,9 +5,11 @@ * LICENSE file in the root directory of this source tree. */ -export default () => [ +const absoluteLoad = () => [ { id: 1, name: '1' }, { id: 2, name: '2' }, { id: 3, name: '3' }, { id: 4, name: '4' }, ]; + +export default absoluteLoad; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/config/BaseUrl.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/config/BaseUrl.js index 818d4db271b..8a4c55a92e2 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/config/BaseUrl.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/config/BaseUrl.js @@ -9,7 +9,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import load from 'absoluteLoad'; -export default class extends Component { +export default class BaseUrl extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ExpandEnvVariables.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ExpandEnvVariables.js index 58fc00e3a5c..f364ed1d932 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ExpandEnvVariables.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ExpandEnvVariables.js @@ -7,7 +7,7 @@ import React from 'react'; -export default () => ( +const ExpandEnvVariables = () => ( {process.env.REACT_APP_BASIC} {process.env.REACT_APP_BASIC_EXPAND} @@ -19,3 +19,5 @@ export default () => ( ); + +export default ExpandEnvVariables; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/FileEnvVariables.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/FileEnvVariables.js index c601d2efd3c..7855d7ac5ec 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/FileEnvVariables.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/FileEnvVariables.js @@ -7,7 +7,7 @@ import React from 'react'; -export default () => ( +const FileEnvVariables = () => ( {process.env.REACT_APP_ORIGINAL_1} @@ -22,3 +22,5 @@ export default () => ( {process.env.REACT_APP_X} ); + +export default FileEnvVariables; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/PublicUrl.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/PublicUrl.js index f3df96a3564..6b8891f9f45 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/PublicUrl.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/PublicUrl.js @@ -7,6 +7,8 @@ import React from 'react'; -export default () => ( +const PublicUrl = () => ( {process.env.PUBLIC_URL}. ); + +export default PublicUrl; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ShellEnvVariables.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ShellEnvVariables.js index 2543779ac1f..72380484b62 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ShellEnvVariables.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/env/ShellEnvVariables.js @@ -7,8 +7,10 @@ import React from 'react'; -export default () => ( +const ShellEnvVariables = () => ( {process.env.REACT_APP_SHELL_ENV_MESSAGE}. ); + +export default ShellEnvVariables; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArrayDestructuring.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArrayDestructuring.js index ac76bd31397..4a27c0c019d 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArrayDestructuring.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArrayDestructuring.js @@ -17,7 +17,7 @@ function load() { ]; } -export default class extends Component { +export default class ArrayDestructuring extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArraySpread.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArraySpread.js index 7832af8b10d..268e800a33a 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArraySpread.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArraySpread.js @@ -17,7 +17,7 @@ function load(users) { ]; } -export default class extends Component { +export default class ArraySpread extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/AsyncAwait.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/AsyncAwait.js index ba0439be493..f098b3f3629 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/AsyncAwait.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/AsyncAwait.js @@ -27,7 +27,7 @@ const x = async ( }; /* eslint-enable */ -export default class extends Component { +export default class AsyncAwait extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ClassProperties.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ClassProperties.js index c58799fb045..532c1fbe4d2 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ClassProperties.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ClassProperties.js @@ -8,7 +8,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; -export default class extends Component { +export default class ClassProperties extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ComputedProperties.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ComputedProperties.js index ad27b8bb23c..4787dc1cd0b 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ComputedProperties.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ComputedProperties.js @@ -17,7 +17,7 @@ function load(prefix) { ]; } -export default class extends Component { +export default class ComputedProperties extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/CustomInterpolation.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/CustomInterpolation.js index 9d894de1336..79b40c0a92d 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/CustomInterpolation.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/CustomInterpolation.js @@ -24,7 +24,7 @@ function load() { ]; } -export default class extends Component { +export default class CustomInterpolation extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DefaultParameters.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DefaultParameters.js index e9beaf7cf38..0a72a0025dc 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DefaultParameters.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DefaultParameters.js @@ -17,7 +17,7 @@ function load(id = 0) { ]; } -export default class extends Component { +export default class DefaultParameters extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DestructuringAndAwait.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DestructuringAndAwait.js index 401ab52dcc9..bd6d2bd6cd7 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DestructuringAndAwait.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/DestructuringAndAwait.js @@ -19,7 +19,7 @@ async function load() { }; } -export default class extends Component { +export default class DestructuringAndAwait extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Generators.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Generators.js index a4853d4d9e8..a6ca041eaaf 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Generators.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Generators.js @@ -16,7 +16,7 @@ function* load(limit) { } } -export default class extends Component { +export default class Generators extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/NullishCoalescing.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/NullishCoalescing.js index ed5f916399c..a514352f454 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/NullishCoalescing.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/NullishCoalescing.js @@ -17,7 +17,7 @@ function load() { ]; } -export default class extends Component { +export default class NullishCoalescing extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectDestructuring.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectDestructuring.js index 14b06f7a4cc..487c546166f 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectDestructuring.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectDestructuring.js @@ -17,7 +17,7 @@ function load() { ]; } -export default class extends Component { +export default class ObjectDestructuring extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectSpread.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectSpread.js index 3c62e38c988..d1fda91b191 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectSpread.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ObjectSpread.js @@ -17,7 +17,7 @@ function load(baseUser) { ]; } -export default class extends Component { +export default class ObjectSpread extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/OptionalChaining.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/OptionalChaining.js index 5b0fd1e3e47..1274eff76da 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/OptionalChaining.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/OptionalChaining.js @@ -17,7 +17,7 @@ function load() { ]; } -export default class extends Component { +export default class OptionalChaining extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Promises.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Promises.js index f71bdf899e0..01b2c513b1f 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Promises.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/Promises.js @@ -17,7 +17,7 @@ function load() { ]); } -export default class extends Component { +export default class Promises extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestAndDefault.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestAndDefault.js index b8e52d6082d..5fa8a8a0bb3 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestAndDefault.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestAndDefault.js @@ -17,7 +17,7 @@ function load({ id, ...rest } = { id: 0, user: { id: 42, name: '42' } }) { ]; } -export default class extends Component { +export default class RestAndDefault extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestParameters.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestParameters.js index b4a9c4c0320..2080245c16e 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestParameters.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/RestParameters.js @@ -17,7 +17,7 @@ function load({ id = 0, ...rest }) { ]; } -export default class extends Component { +export default class RestParameters extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/TemplateInterpolation.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/TemplateInterpolation.js index df3df100ec6..da80f7fff6d 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/TemplateInterpolation.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/TemplateInterpolation.js @@ -17,7 +17,7 @@ function load(name) { ]; } -export default class extends Component { +export default class TemplateInterpolation extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssInclusion.js index 868a886a29d..71fa17890b4 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssInclusion.js @@ -8,4 +8,8 @@ import React from 'react'; import './assets/style.css'; -export default () =>

We love useless text.

; +const CssInclusion = () => ( +

We love useless text.

+); + +export default CssInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssModulesInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssModulesInclusion.js index 05339e3fae1..e6175bfee78 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssModulesInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/CssModulesInclusion.js @@ -9,7 +9,7 @@ import React from 'react'; import styles from './assets/style.module.css'; import indexStyles from './assets/index.module.css'; -export default () => ( +const CssModulesInclusion = () => (

CSS Modules are working!

@@ -17,3 +17,5 @@ export default () => (

); + +export default CssModulesInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/DynamicImport.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/DynamicImport.js index e0c629159b4..2651ab93db7 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/DynamicImport.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/DynamicImport.js @@ -7,6 +7,8 @@ import React from 'react'; -export default () => { +const DynamicImport = () => { return <>Hello World!; }; + +export default DynamicImport; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ImageInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ImageInclusion.js index 1a57bc36d66..6c669339a5f 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ImageInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ImageInclusion.js @@ -8,6 +8,8 @@ import React from 'react'; import tiniestCat from './assets/tiniest-cat.jpg'; -export default () => ( +const ImageInclusion = () => ( tiniest cat ); + +export default ImageInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/JsonInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/JsonInclusion.js index 653c3e74440..97f782f515c 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/JsonInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/JsonInclusion.js @@ -8,4 +8,8 @@ import React from 'react'; import { abstract } from './assets/abstract.json'; -export default () => {abstract}; +const JsonInclusion = () => ( + {abstract} +); + +export default JsonInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/LinkedModules.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/LinkedModules.js index 98ead2deceb..a19091f6e35 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/LinkedModules.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/LinkedModules.js @@ -9,10 +9,12 @@ import React from 'react'; import './assets/style.css'; import { test, version } from 'test-integrity'; -export default () => { +const LinkedModules = () => { const v = version(); if (!test() || v !== '2.0.0') { throw new Error('Functionality test did not pass.'); } return

{v}

; }; + +export default LinkedModules; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/NoExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/NoExtInclusion.js index 0eb7942444c..3b02085113f 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/NoExtInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/NoExtInclusion.js @@ -12,8 +12,10 @@ const text = aFileWithoutExt.includes('base64') ? atob(aFileWithoutExt.split('base64,')[1]).trim() : aFileWithoutExt; -export default () => ( +const NoExtInclusion = () => ( aFileWithoutExt ); + +export default NoExtInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassInclusion.js index c15f175dbfe..def7f4bbdf1 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassInclusion.js @@ -8,4 +8,8 @@ import React from 'react'; import './assets/sass-styles.sass'; -export default () =>

We love useless text.

; +const SassInclusion = () => ( +

We love useless text.

+); + +export default SassInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassModulesInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassModulesInclusion.js index 7f9837a7981..ff7341d8734 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassModulesInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SassModulesInclusion.js @@ -9,7 +9,7 @@ import React from 'react'; import styles from './assets/sass-styles.module.sass'; import indexStyles from './assets/index.module.sass'; -export default () => ( +const SassModulesInclusion = () => (

SASS Modules are working!

@@ -17,3 +17,5 @@ export default () => (

); + +export default SassModulesInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssInclusion.js index b363f430ea8..8c6a9d81bb9 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssInclusion.js @@ -8,4 +8,8 @@ import React from 'react'; import './assets/scss-styles.scss'; -export default () =>

We love useless text.

; +const ScssInclusion = () => ( +

We love useless text.

+); + +export default ScssInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssModulesInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssModulesInclusion.js index cd12dce3b21..bfc0338a3cf 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssModulesInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/ScssModulesInclusion.js @@ -9,7 +9,7 @@ import React from 'react'; import styles from './assets/scss-styles.module.scss'; import indexStyles from './assets/index.module.scss'; -export default () => ( +const ScssModulesInclusion = () => (

SCSS Modules are working!

@@ -17,3 +17,5 @@ export default () => (

); + +export default ScssModulesInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgComponent.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgComponent.js index b22cb2fe056..d7d6dafeb33 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgComponent.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgComponent.js @@ -8,10 +8,12 @@ import React from 'react'; import { ReactComponent as Logo } from './assets/logo.svg'; -export default () => { +const SvgComponent = () => { return ; }; export const SvgComponentWithRef = React.forwardRef((props, ref) => ( )); + +export default SvgComponent; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInCss.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInCss.js index edf34137940..ff9ff180da1 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInCss.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInCss.js @@ -1,4 +1,6 @@ import React from 'react'; import './assets/svg.css'; -export default () =>
; +const SvgInCss = () =>
; + +export default SvgInCss; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInclusion.js index c519423e6dc..7ef580c0103 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInclusion.js @@ -8,4 +8,8 @@ import React from 'react'; import logo from './assets/logo.svg'; -export default () => logo; +const SvgInclusion = () => ( + logo +); + +export default SvgInclusion; diff --git a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/UnknownExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/UnknownExtInclusion.js index bdb81f17883..1fe2720f56e 100644 --- a/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/UnknownExtInclusion.js +++ b/packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/UnknownExtInclusion.js @@ -12,8 +12,10 @@ const text = aFileWithExtUnknown.includes('base64') ? atob(aFileWithExtUnknown.split('base64,')[1]).trim() : aFileWithExtUnknown; -export default () => ( +const UnknownExtInclusion = () => ( aFileWithExtUnknown ); + +export default UnknownExtInclusion; diff --git a/test/fixtures/node_path/src/App.js b/test/fixtures/node_path/src/App.js index ba7136fc0aa..0dcfa10fc69 100644 --- a/test/fixtures/node_path/src/App.js +++ b/test/fixtures/node_path/src/App.js @@ -10,7 +10,7 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; import load from 'absoluteLoad'; -export default class extends Component { +export default class App extends Component { static propTypes = { onReady: PropTypes.func.isRequired, }; diff --git a/test/fixtures/node_path/src/absoluteLoad.js b/test/fixtures/node_path/src/absoluteLoad.js index 5c4f7842e28..72da1c69042 100644 --- a/test/fixtures/node_path/src/absoluteLoad.js +++ b/test/fixtures/node_path/src/absoluteLoad.js @@ -5,9 +5,11 @@ * LICENSE file in the root directory of this source tree. */ -export default () => [ +const absoluteLoad = () => [ { id: 1, name: '1' }, { id: 2, name: '2' }, { id: 3, name: '3' }, { id: 4, name: '4' }, ]; + +export default absoluteLoad;