From 242d034fa0f9d782559b487387335fabd13c1291 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ezgi=20=C3=87i=C3=A7ek?= Date: Thu, 30 Jan 2025 05:16:08 -0800 Subject: [PATCH] Add a test showing duplicate external config entries in event log Summary: See next diff for explanation Reviewed By: IanChilds Differential Revision: D68839204 fbshipit-source-id: b81042e9784ba84736965c0af81923ed64fa0afb --- tests/core/build/test_external_buckconfigs.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/tests/core/build/test_external_buckconfigs.py b/tests/core/build/test_external_buckconfigs.py index 6f40e4d54a68..0e895d00eb8c 100644 --- a/tests/core/build/test_external_buckconfigs.py +++ b/tests/core/build/test_external_buckconfigs.py @@ -35,11 +35,26 @@ async def test_external_buckconfigs(buck: Buck) -> None: "--config-file", f.name, ) + # Make a spurious file change to trigger DICE updater state comparison + with open(buck.cwd / "src", "w") as src: + src.write("test") - external_configs = await filter_events( + await buck.build( + "@root//mode/my_mode", + "//:test", + "-c", + "my_section.my_key=my_value", + "--config-file", + f.name, + ) + + buckconfig_input_values = await filter_events( buck, "Event", "data", "Instant", "data", "BuckconfigInputValues", "components" ) - external_configs = external_configs[0] + # Currently, when there are file changes in between, we end up having two BuckconfigInputValues events. + # Will be fixed in the next diff. + assert len(buckconfig_input_values) == 2 + external_configs = buckconfig_input_values[0] assert len(external_configs) == 4 external_index = 0