From a8851c121efa70311a55c09cb0f1de6a3c50438d Mon Sep 17 00:00:00 2001 From: Artem Pianykh Date: Mon, 13 Jan 2025 01:59:22 -0800 Subject: [PATCH] Disable link order fixup until the perf fix is ready Summary: The change in D67197102 makes the link order in link groups consistent with the _regular_ link order. However, the implementation has a perf and memory impact that affects e.g. Glean indexing. The perf fix is underway but until it's ready we should temporarily disable the link order fixup. #buildall Reviewed By: patskovn, iamirzhan Differential Revision: D68074196 fbshipit-source-id: e04cbde765db3e5c7342dc430c2e67e875e1be98 --- cxx/link_groups.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cxx/link_groups.bzl b/cxx/link_groups.bzl index 02c6a216d..dffdec708 100644 --- a/cxx/link_groups.bzl +++ b/cxx/link_groups.bzl @@ -446,7 +446,7 @@ def get_filtered_labels_to_links_map( link_group_preferred_linkage, pic_behavior, roots, - fixup_link_order = link_strategy == LinkStrategy("shared"), + fixup_link_order = False, # TODO(arr): re-enable when the perf fix D67982726 is ready ) # An index of target to link group names, for all link group library nodes.