Skip to content

Commit 2718d6f

Browse files
thedoddcdbfoster
authored andcommitted
Set whoami default-features to false (launchbadge#2319)
* Fixed typo. (launchbadge#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <[email protected]>
1 parent 113f0bb commit 2718d6f

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

Cargo.lock

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sqlx-mysql/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ smallvec = "1.7.0"
6161
stringprep = "0.1.2"
6262
thiserror = "1.0.35"
6363
tracing = { version = "0.1.37", features = ["log"] }
64-
whoami = "1.2.1"
64+
whoami = { version = "1.2.1", default-features = false }
6565

6666
serde = { version = "1.0.144", optional = true }
6767

sqlx-postgres/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ smallvec = "1.7.0"
6262
stringprep = "0.1.2"
6363
thiserror = "1.0.35"
6464
tracing = { version = "0.1.37", features = ["log"] }
65-
whoami = "1.2.1"
65+
whoami = { version = "1.2.1", default-features = false }
6666

6767
serde = { version = "1.0.144", features = ["derive"] }
6868
serde_json = { version = "1.0.85", features = ["raw_value"] }

src/macros/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ macro_rules! query_file_scalar_unchecked (
733733
///
734734
/// This is because our ability to tell the compiler to watch external files for changes
735735
/// from a proc-macro is very limited. The compiler by default only re-runs proc macros when
736-
/// one ore more source files have changed, because normally it shouldn't have to otherwise. SQLx is
736+
/// one or more source files have changed, because normally it shouldn't have to otherwise. SQLx is
737737
/// just weird in that external factors can change the output of proc macros, much to the chagrin of
738738
/// the compiler team and IDE plugin authors.
739739
///

0 commit comments

Comments
 (0)