Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group.addWithUpdate should leverage Group.add. #6619

Closed
asturur opened this issue Sep 26, 2020 · 1 comment
Closed

Group.addWithUpdate should leverage Group.add. #6619

asturur opened this issue Sep 26, 2020 · 1 comment
Labels
beginner-friendly feature

Comments

@asturur
Copy link
Member

asturur commented Sep 26, 2020

We should reuse the code in some specific functions rather than duplicating it.
AddWithUpdate is supposed to Add and do extra work for the update.

Group.add should be reused so that eventual changes will go automatically in addWithUpdate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asturur @ShaMan123