Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getExistingSharedIndexInformer may Incorrect #3235

Closed
FqqCS opened this issue Jun 10, 2021 · 3 comments · Fixed by #3230
Closed

getExistingSharedIndexInformer may Incorrect #3235

FqqCS opened this issue Jun 10, 2021 · 3 comments · Fixed by #3230

Comments

@FqqCS
Copy link

FqqCS commented Jun 10, 2021

 private static <T> boolean isKeyOfType(String key, Class<T> apiTypeClass) {
        String plural = HasMetadata.getPlural(apiTypeClass);
        return key.contains(plural);
    }

this may incorrect: return key.contains(plural);
for example: virtualservice and service

@rohanKanojia
Copy link
Member

yes, you're right. I'm trying to remove this string key creation logic in #3230

@rohanKanojia
Copy link
Member

@FqqCS : I've added a test case for your use case in https://github.com/fabric8io/kubernetes-client/pull/3230/files#diff-775882ab5373e4fd32c8a42e81a80feabcc3e699f7346f3c171b5cd940516a59R123 .

Would be awesome if you could review

@manusa
Copy link
Member

manusa commented Jun 23, 2021

Relates to: #2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants