Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitUntilCondition: configurable poll rate #2315

Closed
sbaier1 opened this issue Jun 26, 2020 · 3 comments
Closed

waitUntilCondition: configurable poll rate #2315

sbaier1 opened this issue Jun 26, 2020 · 3 comments

Comments

@sbaier1
Copy link

sbaier1 commented Jun 26, 2020

Currently, waitUntilCondition still polls the current state from the API server every 500ms(!!) statically, which is pretty damn often IMHO.

It seems to me like this is pretty harsh on the API server to be queried that frequently when waiting for a condition like a roll-out of a Deployment finishing.

Can you overload the method to add a parameter to configure the poll rate, or a function parameter to allow custom back-off functions, or just straight implement exponential back-off that resets when the resource changes or something like that?

@rohanKanojia
Copy link
Member

Umm, Could you please share kubernetes-client version? I remember this was refactored to use watcher in #2239

@sbaier1
Copy link
Author

sbaier1 commented Jun 26, 2020

Oh sure, sorry. I am using 4.10.1, so it makes sense that this is outdated on my part.

I've been encountering a problem with 4.10.2 that prohibited me from upgrading to the latest version and therefore i have not upgraded yet:

I'm using DefaultKubernetesClient#load(InputStream) to load a rendered template, which worked in 4.10.1 but throws a Jackson exception like No resource type found for:Deployment in 4.10.2. Should i raise an issue with a reproducer for this instead?

@rohanKanojia
Copy link
Member

@sbaier1 : Yes, that would be appreciated.

@sbaier1 sbaier1 closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants