Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw Custom Resources API createOrReplace does not handle create failures gracefully #2285

Closed
bbeaudreault opened this issue Jun 13, 2020 · 0 comments · Fixed by #2289
Closed

Comments

@bbeaudreault
Copy link
Contributor

I'm hoping to get to this this week but wanted to make an issue to keep track of:

the RawCustomResourceOperationsImpl#createOrReplace does a create, catches the exception, and then does a replace. The idea here I'm guessing is that create would fail if the resource already exists, but create can fail for other reasons as well. Any exception that's not related to the resource already existing should be propagated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants