Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add labels from label-schema.org to the generators #456

Closed
jstrachan opened this issue Sep 30, 2016 · 7 comments
Closed

Add labels from label-schema.org to the generators #456

jstrachan opened this issue Sep 30, 2016 · 7 comments
Assignees
Labels
cat/feature Feature request group/generator Generator related prio/p2 Some priority size/m Medium

Comments

@jstrachan
Copy link
Contributor

microbadger looks cool
https://microbadger.com/

and has a set of canonical docker labels we should automatically add into our docker images as part of a build

@jstrachan
Copy link
Contributor Author

doh raised it here too:
fabric8io/docker-maven-plugin#492

but at the fabric8 layer we know a bit more about the image already I guess and can reuse metadata from the kubernetes annotations etc

@jstrachan
Copy link
Contributor Author

e.g. we already have lots of the git URL / tags / jenkins build stuff as annotations in the yaml

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rhuss
Copy link
Contributor

rhuss commented Oct 6, 2018

We should add the "standard" labels fromhttp://label-schema.org/rc1/ and add it via the generator for all the information we find.

@stale stale bot removed the status/stale Issue/PR considered to be stale label Oct 6, 2018
@rhuss rhuss changed the title auto-generate microbadger metadata as part of a fabric8 / docker build? Add labels from label-schema.org to the generators Oct 6, 2018
@rhuss rhuss added cat/feature Feature request prio/p2 Some priority size/m Medium group/generator Generator related labels Oct 6, 2018
@stale
Copy link

stale bot commented Jan 4, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Jan 4, 2019
@rohanKanojia rohanKanojia removed the status/stale Issue/PR considered to be stale label Jan 5, 2019
@devang-gaur devang-gaur self-assigned this Jan 23, 2019
@devang-gaur
Copy link
Contributor

@rhuss what all labels fall under the 'standard' category here http://label-schema.org/rc1/ ?

Which don't start with docker.* or rkt.* ?

@lordofthejars @rohanKanojia

@devang-gaur
Copy link
Contributor

Apparently, S2I doesn't allow to override images labels.
s2i build . centos/ruby-22-centos7 hello-world-app

Though, s2i images do have schema labels of their own, these are the labels in the fabric8/s2i-java image.

image

So, I think I'll only append the schema labels for Kubernetes mode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature Feature request group/generator Generator related prio/p2 Some priority size/m Medium
Projects
None yet
Development

No branches or pull requests

4 participants