-
Notifications
You must be signed in to change notification settings - Fork 12
[.NET Core 2.0] Add stack detector for .NET Core 2.0 #47
Comments
would we have 3 separate che stacks for C#, VB.NET and F#? or just one? how about if we go with these rules for che stack mappings?
unless just 1 che stack is enough? |
I should have asked the obvious question first I guess - do we have any Che stack(s) for .Net Core 2.0 yet and if so what are they called? |
@dharmit, do you know what the name of the final RHEL and/or CentOS-based dotnet stack will be?
A single Then again, I don't know if something from che (such as language server for C# vs F#) may require us to use separate stacks. @gorkem Do you have any suggestions? |
|
Che has only C# LSP support which was tested against this stack earlier |
Whatever the current conventions are! I know the rhel container (not stack, no che integration, just a basic s2i container for .NET Core 2.0) is called |
I have an example at https://github.com/omajid/HelloWorld/, specifically the |
fabric8-generator/src/main/java/io/fabric8/forge/generator/che/CheStackDetector.java
Line 62 in d9e0541
.NET Core projects use either a solution (
*.sln
) file - if the repository contains multiple projects - or the following more specific project types:*.csproj
for C#*.vbproj
for VB.NET*.fsproj
for F#We should look for these files and use them to identify the right che stack to use.
The text was updated successfully, but these errors were encountered: