created retry button on progress screen #277
Conversation
ghost
assigned 
edewit
changed the title
|
This PR does introduce some API changes in the services. Will create one for fabric8-ui as well |
edewit
force-pushed
the
retry
branch
2 times, most recently
from
5490db2 to
12351b7
Compare
edewit
changed the title
|
implements this design: https://redhat.invisionapp.com/share/VGF1RF15J#/screens/286893674 |
|
@ia3andy @invincibleJai can you review? |
|
@edewit looks like it needs changes in fabric8-ui as well , are you planning to have PR their as well? if am not wrong you already raised PR in fabric8-ui for it right?
|
| * @returns {Observable<any>} | ||
| */ | ||
| abstract getCurrentContext(): Observable<any>; | ||
| abstract setup(summary: Summary, retry?: number): Observable<any>; |
There was a problem hiding this comment.
Is spaceId not needed for /launch anymore ?
There was a problem hiding this comment.
Yes it's still needed, but it would fetch spaceId from fabric8-ui and then pass it again here. So simpler would be to keep it on the fabric8-ui see fabric8-ui/fabric8-ui#3019
There was a problem hiding this comment.
tried with fabric8-ui/fabric8-ui#3019 looks good!!
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes: #239