-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add LICENSE file into the sub-crates #94
Conversation
Those are released separately on crates.io and they do not contain LICENSE file now that is required when packaging them in Linux distributions. Signed-off-by: Igor Raits <[email protected]>
Good point! Thanks for your contribution @ignatenkobrain but I am curious wouldn't it be better to add them as actual files instead of symlinks? I just realise that crates.io takes a snapshot of the crate on publish and I don't even know what it does when there is a symlink in there: https://docs.rs/crate/asyncgit/0.4.0/source/ |
@extrawurst as long as you don't try to publish crate from windows machine, it will be fine (many projects are using it this way). |
it will be converted to the real file since cargo will resolve any symlinks when publishing. |
Perfect! Thanks four your input, I did not know that! |
@ignatenkobrain did this come up in adding |
@extrawurst I have a package under review now in Fedora. Once I build it for stable releases, I'll send update to the README :) |
#95 here you go @extrawurst :) Thanks for working on this project! I found it quite nice and will open few RFEs tomorrow :) |
@ignatenkobrain what is an RFE? 🙈 |
Request For Enhancement :) Basically I miss opening a commit from commit list that can show diff in some nice view. Aka git show, but better. Also searching capabilities in commits are quite limited now. |
Those are released separately on crates.io and they do not contain
LICENSE file now that is required when packaging them in Linux
distributions.
Signed-off-by: Igor Raits [email protected]