New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix double key input on windows due to crossterm 0.26 #1686

Merged

extrawurst merged 1 commit into gitui-org:master from pm100:winct26

May 14, 2023

Contributor

pm100 commented May 11, 2023

crossterm 0.26 adds key release event on windows, this causes all key inputs to be duplicated in apps that dont explciitly look at the key event type

It changes the following:

in input.rs is not key press then skip input

I followed the checklist:

I added unittests
[ x] I ran make check without errors
[ x] I tested the overall application
I added an appropriate item to the changelog


          fix double key input on windows due to crossterm 0.26

76fca58

Contributor Author

pm100 commented May 11, 2023 •

edited

Loading

note that the CI is failing due to the 1.65 shift requirement

extrawurst merged commit aa4266c into gitui-org:master

pm100 deleted the winct26 branch

May 15, 2023 14:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet