-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore whitespace does not work in Log [2] view #1661
Labels
Milestone
Comments
kamillo
added a commit
to kamillo/gitui
that referenced
this issue
May 6, 2023
kamillo
added a commit
to kamillo/gitui
that referenced
this issue
May 7, 2023
* Pass SharedOptions to InspectCommitComponent and CompareCommitsComponent
4 tasks
extrawurst
pushed a commit
that referenced
this issue
Jun 19, 2023
Thank you sir |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this issue
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Hi, truly an amazing project, and thank you for making it. I can click
.
for more options, typeo
for options, and then navigate to "Ignore whitespace" and change to true.This works (!) thank you. But it only works for "Status [1]" view. But it does not work for "Log [2]" view after navigating to a commit.
To Reproduce
Steps to reproduce the behavior:
.
for more optionso
for optionstab
to open Log [2]Expected behavior
No whitespaces in dif.
Screenshots

Context (please complete the following information):
Additional context
I tried following https://github.com/extrawurst/gitui/blob/master/src/tabs/revlog.rs to find missing link of options. I see at https://github.com/extrawurst/gitui/blob/289eddd9beeffeb57ca3ae9f55380dd05996c23a/asyncgit/src/sync/commit_files.rs#L24 the options are not passed, but I do not know about the codebase.
I posted first on #1147 but then created new issue.
The text was updated successfully, but these errors were encountered: