Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows msi installer #164

Closed
extrawurst opened this issue Jun 30, 2020 · 9 comments
Closed

Windows msi installer #164

extrawurst opened this issue Jun 30, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed windows

Comments

@extrawurst
Copy link
Collaborator

Inspired by usage of wix in nushell: fdncred/nushell@c58a456#diff-56c30d9224897b08c28075052d4595c5

@non-descriptive
Copy link

maybe add chocolatey packages as well?

@kdebowski
Copy link

I would love to see gitui in Scoop repository

@extrawurst
Copy link
Collaborator Author

I am not using windows, so I am very much depending on some contribution here.

@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 27, 2020
@rashil2000
Copy link

rashil2000 commented Sep 14, 2020

gitui is there in the main bucket of Scoop.
@extrawurst Just add a section like this to the Readme in this repo.

Scoop (Windows)

scoop install gitui

It's really easy (as evident) but I can open a PR for the same if you want.

@extrawurst
Copy link
Collaborator Author

@rashil2000 thanks for pointing it out, its added!

@pm100
Copy link
Contributor

pm100 commented Oct 23, 2020

I have created an installer for gitui using that toolkit. Works great

I have no idea how to integrate it into the github CI process. I will look see how nushell does it

the actions needed are very simple.
install .net 3.5
install wix sdk

I dont know how to do this. When I look at nushell they do not do this in their build script. I dont know enough about how the servers that run github pipeline are setup

with those installed the rest is simple

install cargo-wix

  - name: Add cargo-wix subcommand
    uses: actions-rs/cargo@v1
    with:
      command: install
      args: cargo-wix

then run it

  - name: Create msi with wix
    uses: actions-rs/cargo@v1
    with:
      command: wix
      args: --no-build --nocapture --output target\wix\nushell-windows.msi

presto you have your MSI

I dont know how to do any github toolchain, can I just hack them in my fork. When I fork github says they are disabled.

I assume your cd.yml is the one I would need to modify

@extrawurst
Copy link
Collaborator Author

@pm100 thanks for tackling this. cd.yml only runs when we tag a new release. ci.yml runs on each commit you should be able to open a draft PR and the CI should run

@extrawurst
Copy link
Collaborator Author

@pm100:

you sure about that? ci.yml does not build any of the install assets, cd is the one that does it. You only really need to build the msi when you bless a release. For sure I can use ci to test it out

Maybe I should have been more clear: yes ultimately we need to adjust the CD but for the purpose of testing we use CI until we see it works correctly

@extrawurst
Copy link
Collaborator Author

Closed in #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed windows
Projects
None yet
Development

No branches or pull requests

5 participants