Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eas submit -p ios with app version management is not working correctly #2161

Closed
siarheipashkevich opened this issue Dec 21, 2023 · 3 comments
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@siarheipashkevich
Copy link

Build/Submit details page URL

https://expo.dev/accounts/esupldevelopers/projects/esupl-kds/submissions/118fa60f-67e7-42e0-b336-73ca1c94d8f2

Summary

App Store rejects submission when I use "appVersionSource": "remote" for managing versioning.

https://expo.dev/accounts/esupldevelopers/projects/esupl-kds/submissions/118fa60f-67e7-42e0-b336-73ca1c94d8f2

image image

Managed or bare?

managed

Environment

image image

Error output

You've already submitted this version of the app.
Versions are identified by CFBundleShortVersionString from Info.plist (expo.version in app.json).
If you're submitting an Expo project built with EAS Build, increment the version (expo.version) in app.json and build the project again.

Reproducible demo or steps to reproduce from a blank project

eas build -p ios --auto-submit

@siarheipashkevich siarheipashkevich added the needs review Issue is ready to be reviewed by a maintainer label Dec 21, 2023
@szdziedzic
Copy link
Member

Hi,

You are getting this error because if an app version [1.0.0] is already approved, you must increase the version number [1.0.1]. If you increase the buildNumber you will get the same error. With that being said, the autoIncrement option only bumps the versionCode/buildNumber. It is a known limitation that it does not support bumping version automatically.

https://docs.expo.dev/build-reference/app-versions/#remote-version-source

@siarheipashkevich
Copy link
Author

Hi @szdziedzic, in that case it is not auto increment flow. Because we need manually increase the version number locally and commit this and only after that we should do submit ?

@szdziedzic
Copy link
Member

I mean it's technically auto-incrementing your versionCode/buildNumber so in my opinion autoIncrement is a valid name, but I'm open to suggestions if you think it should be renamed. But yeah, I agree this autoIncrement version management process is only partially automated and it still requires some human action every time the new version is approved, that's right.

I see your standpoint and what you would like this feature to do. It is reasonable thinking and I understand you. However, it was built with this thought in mind:

The main goal of this feature is to avoid manual changes to the project every time you are uploading a new archive to run it on TestFlight/Play Store testing channels. When you are doing a production release, the user-facing version change should be explicit.

https://docs.expo.dev/build-reference/app-versions/#recommended-workflow

With that being said, we can consider implementing it in the future if this highly requested feature and when we finish building the features we currently prioritize.

Thanks for the discussion and let me know if you have any more questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants