Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[ignore] isn't sufficient to hide tests from compilation. #275

Closed
jcdyer opened this issue Apr 21, 2017 · 3 comments
Closed

#[ignore] isn't sufficient to hide tests from compilation. #275

jcdyer opened this issue Apr 21, 2017 · 3 comments

Comments

@jcdyer
Copy link

jcdyer commented Apr 21, 2017

Tests marked with #[ignore] still have to type check in order to compile, so you more or less have to complete the exercise to get the first test to pass. In order to better facilitate incremental development using TDD practices, I suggest we actually comment out the tests instead of annotating them.

@ijanos
Copy link
Contributor

ijanos commented Apr 21, 2017

Thanks you for pointing that out. We have another discussion #269 about placeholder lib.rs files. If we provide those with the right signatures this one became a non-issue because the empty exercises will compile without an issue as all tests will compile. Would that be a good solution for you?

@jcdyer
Copy link
Author

jcdyer commented Apr 21, 2017

I'm okay with either approach, though I think I mildly prefer having users write functions from scratch, as learning how to appease the typechecker is a large part of learning rust.

@jcdyer
Copy link
Author

jcdyer commented Apr 21, 2017

Closing this as a duplicate of #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants