Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangram: Add tests for accented characters and non-latin scripts #1048

Closed
isani opened this issue Dec 22, 2017 · 4 comments
Closed

Pangram: Add tests for accented characters and non-latin scripts #1048

isani opened this issue Dec 22, 2017 · 4 comments

Comments

@isani
Copy link

isani commented Dec 22, 2017

On the csharp track, many pangram solutions use the built-in method IsLetter(char). This method matches more than a-z, which leads to wrong results when the input contains Unicode letters. There are currently no tests that contain letters outside the a-z range, and thus a range of bugs are not caught.

The following strings should be tested as not pangrams (because they don't contain an 'a'):

"äbcdefghijklmnopqrstuvwxyz"
"αbcdefghijklmnopqrstuvwxyz"

The following strings should be tested as pangrams (to ensure input with Unicode isn't just rejected):

"the quick brown fox jumps over the lazy dög"
"the quick brown fox jumps over the lazy dөg"

@NobbZ
Copy link
Member

NobbZ commented Dec 22, 2017

Due to very different support of unicode across languages the problem-specifications do only cover ASCII (we haven't agreed if we use traditional 7bit or enhenced 8bit yet ;), some people imply the one, some people imply the other when reading ASCII).

If a language does cope well with Unicode handling, then its in the responsibility of the tracks maintainers to avoid and test against unicode pitfalls of that language.

Can you therefore file a bug at the C# issue tracker?

cc @exercism/csharp

@coriolinus
Copy link
Member

This has been discussed before in #428.

@NobbZ
Copy link
Member

NobbZ commented Dec 22, 2017

Oh, it seems as if I am allowed to close here, so I'll move the issue over to C# repo directly.

@NobbZ
Copy link
Member

NobbZ commented Dec 22, 2017

Issue moved to exercism/csharp #502 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants