From ad4b87575dd2072310e304fd6945ded1c783ee25 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 27 Jan 2024 13:41:55 +0100 Subject: [PATCH 1/5] Fix typo in array introduction --- concepts/arrays/introduction.md | 3 +-- exercises/concept/language-list/.docs/introduction.md | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/concepts/arrays/introduction.md b/concepts/arrays/introduction.md index ec617316..5a203a4d 100644 --- a/concepts/arrays/introduction.md +++ b/concepts/arrays/introduction.md @@ -15,7 +15,7 @@ $no_keys == $integer_keys // => equal returns true $no_keys === $integer_keys // => strictly equal returns true ``` -A values are of `mixed` type, and each value in an array is not required to be of the same type. +All values are of `mixed` type, and each value in an array is not required to be of the same type. ## Using Arrays @@ -29,4 +29,3 @@ $prime_numbers[5] = 13; // replace 12 with 13 $prime_numbers[] = 17; // array now contains [1, 3, 5, 7, 11, 13, 17] ``` - diff --git a/exercises/concept/language-list/.docs/introduction.md b/exercises/concept/language-list/.docs/introduction.md index 96776a56..91048f65 100644 --- a/exercises/concept/language-list/.docs/introduction.md +++ b/exercises/concept/language-list/.docs/introduction.md @@ -17,7 +17,7 @@ $no_keys == $integer_keys // => equal returns true $no_keys === $integer_keys // => strictly equal returns true ``` -A values are of `mixed` type, and each value in an array is not required to be of the same type. +All values are of `mixed` type, and each value in an array is not required to be of the same type. ### Using Arrays From b3fff2ca158039e253786014e2ac155b38e40c51 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 27 Jan 2024 13:43:19 +0100 Subject: [PATCH 2/5] Fix sentence casing in hints --- .../concept/language-list/.docs/hints.md | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/exercises/concept/language-list/.docs/hints.md b/exercises/concept/language-list/.docs/hints.md index 15a2dade..5be9d1d9 100644 --- a/exercises/concept/language-list/.docs/hints.md +++ b/exercises/concept/language-list/.docs/hints.md @@ -3,7 +3,7 @@ ## General - Review the [Array Language Reference][ref-arrays] -- review the [Array Function Reference][ref-array-functions] +- Review the [Array Function Reference][ref-array-functions] ## 1. Define a function to return an empty language list @@ -12,27 +12,27 @@ ## 2. Modify function to create a list from any number of languages -- refer to the function reference for [variable-length-arguments][variable-arguments] +- Refer to the function reference for [variable-length-arguments][variable-arguments] ## 3. Define a function to add a language to the list -- create a new function to perform the operation -- re-use an [existing function][ref-array-functions] or use the [insert syntax][squre-bracket-syntax] +- Create a new function to perform the operation +- Re-use an [existing function][ref-array-functions] or use the [insert syntax][squre-bracket-syntax] ## 4. Define a function to remove an item from the language list -- create a new function to perform the operation -- re-use an [existing function][ref-array-functions] to perform the operation +- Create a new function to perform the operation +- Re-use an [existing function][ref-array-functions] to perform the operation -## 5. Define a function to get the first item in the list +## 5. Define a function to get the first item in the list -- create a new function to perform the operation -- use the [index syntax][index-syntax] to get the first element +- Create a new function to perform the operation +- Use the [index syntax][index-syntax] to get the first element ## 6. Define a function to return how many languages are in the list -- create a new function to perform the operation -- re-use an [existing function][ref-array-functions] to perform the operation +- Create a new function to perform the operation +- Re-use an [existing function][ref-array-functions] to perform the operation [ref-arrays]: https://www.php.net/manual/en/language.types.array.php [ref-array-functions]: https://www.php.net/manual/en/ref.array.php From ed0921dc6857bd44107ae36c075f0751dba2bfc7 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 27 Jan 2024 13:43:37 +0100 Subject: [PATCH 3/5] Fix link in hints --- exercises/concept/language-list/.docs/hints.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/language-list/.docs/hints.md b/exercises/concept/language-list/.docs/hints.md index 5be9d1d9..5ea3b783 100644 --- a/exercises/concept/language-list/.docs/hints.md +++ b/exercises/concept/language-list/.docs/hints.md @@ -17,7 +17,7 @@ ## 3. Define a function to add a language to the list - Create a new function to perform the operation -- Re-use an [existing function][ref-array-functions] or use the [insert syntax][squre-bracket-syntax] +- Re-use an [existing function][ref-array-functions] or use the [insert syntax][square-bracket-syntax] ## 4. Define a function to remove an item from the language list From 89d420ed28fefcce3fb222589d683808d6eb2858 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 27 Jan 2024 13:44:48 +0100 Subject: [PATCH 4/5] Improve wording in instructions of task 2 --- exercises/concept/language-list/.docs/instructions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/language-list/.docs/instructions.md b/exercises/concept/language-list/.docs/instructions.md index 4cfac30e..a45a2655 100644 --- a/exercises/concept/language-list/.docs/instructions.md +++ b/exercises/concept/language-list/.docs/instructions.md @@ -15,7 +15,7 @@ language_list(); ## 2. Modify function to create a list from any number of languages -Modify the `language_list` function, so it takes a variadic argument or string languages. +Modify the `language_list` function, so it takes a variadic argument of languages (strings). It should return the resulting list with the languages in the list. ```php From 8a9b9b34c5d53cc3fe3129007edfc57fe891d890 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sat, 27 Jan 2024 13:45:51 +0100 Subject: [PATCH 5/5] Fix instructions of task 6 See forum request: https://forum.exercism.org/t/language-list-contains-a-couple-of-typos-in-the-instructions/9416 --- exercises/concept/language-list/.docs/instructions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/concept/language-list/.docs/instructions.md b/exercises/concept/language-list/.docs/instructions.md index a45a2655..c8a20bc0 100644 --- a/exercises/concept/language-list/.docs/instructions.md +++ b/exercises/concept/language-list/.docs/instructions.md @@ -78,8 +78,8 @@ It should return the number of languages in the list. ```php ["PHP", "Prolog", "Wren"] language_list_length($language_list); -// => 2 +// => 3 ```