Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the need to remove the @Ignore from other tests in each exercise #130

Closed
duckpuppy opened this issue May 18, 2018 · 5 comments
Closed

Comments

@duckpuppy
Copy link

duckpuppy commented May 18, 2018

In #30, each test after the first was @Ignored with the idea that the student would remove that annotation from the remaining tests. In #30 (comment), it was mentioned that a future PR was inbound to address documenting that. I began the Kotlin track yesterday (5/17/2018) and nowhere in the TUTORIAL.md or README.md for hello-world was there a mention of removing them. I didn't even notice skipped tests until the second lesson, and only because I'm a seasoned developer familiar with testing frameworks did I think to investigate the test file and remove them.

@katrinleinweber
Copy link
Contributor

katrinleinweber commented Oct 5, 2018

@jtigger did that in #31, but it's indeed no longer there. Removed by 119d9b1 in #111.

@mikegehard
Copy link
Contributor

@duckpuppy Do you know if this is still an issue?

@blueglyph
Copy link

@duckpuppy Do you know if this is still an issue?

Hello, this is still an issue as reported in #300, #301 (and other tests)

@mikegehard
Copy link
Contributor

Thanks @blueglyph.

I'll take a look at the commits referenced above and back in some language around the @ignore annotations.

@mikegehard
Copy link
Contributor

I believe this is at least partially addressed by #296 so I'm closing.

If there is more work to be done, please file another issue or open a pull request with specifics.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants