-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ESLint 9 flat config and move to pnpm, use .mjs and new jest types #2548
Conversation
Okay. So. This PR works and relies on exercism/javascript-test-runner#852, but I do not know if that PR will work as it requires the My plan is:
If that works, mark this as ready and we are good to go! If it doesn't work, I will revert the test runner and message Jeremy. |
What a monster PR! Not even sure where to start with this... |
Isn't it fun 📦. Basically: eslint 9, pnpm instead of npm. Check that the instructions to install are clear and that you don't absolutely hate it. |
Looks good from what I could see, appart from a few leftover comments. |
@Cool-Katt where's the comments? |
@SleeplessByte sorry, I accidentally forgot to post the actual review. Lol |
@Cool-Katt apart from those three comments, anything else? |
Everything else looks good to me |
@Cool-Katt if you can approve we can merge! |
@SleeplessByte Just to wrap my head around it, why are we having a separate babel and jest config for each exercise? EDIT: Otherwise looks good, i think |
Because neither likes to be defined in package.json and remember that students download the folders separately! |
Related: exercism/javascript-test-runner#852
Similar to: exercism/typescript#1506
corepack
gets removed in the future, our migration path is as "simple" as removingcorepack
from the calls. Everything keeps working.