Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Install only the GHC we are testing #128

Merged
merged 1 commit into from
Jun 18, 2016
Merged

travis: Install only the GHC we are testing #128

merged 1 commit into from
Jun 18, 2016

Conversation

petertseng
Copy link
Member

This will decrease install times

Closes #119

@petertseng
Copy link
Member Author

The various Travis PRs #118 #120 and #128 will probably have merge conflicts with each other. I can deal with them as the PRs are merged one by one.

@petertseng
Copy link
Member Author

petertseng commented Apr 9, 2016

Hmm. Adds a bit of complexity (yaml references) to the yaml file. I don't have very good measurements on how much time it saves on a build. Maybe 20 seconds per version we no longer install? That's multiplied by 2 currently, and the savings are greater if we test more GHC versions (for example 8.0 as in #120, maybe even 7.4...)

@petertseng
Copy link
Member Author

will rebase in next 24 hours. I can and should be prodded if not.

@petertseng
Copy link
Member Author

petertseng commented Jun 18, 2016

Does Github send notifications when I push new commits to a PR branch? I thought it did Nope, so I still have to notify by comment (let me know if I'm wrong and you in fact did get notifications). I have updated.

@rbasso
Copy link
Contributor

rbasso commented Jun 18, 2016

I just received the two notifications from your messages.

But don't worry! I'm checking it frequently.

Just one more PR to go! 😄

This will decrease install times

Closes #119
@petertseng
Copy link
Member Author

petertseng commented Jun 18, 2016

I'm just going to take a moment to say that I kept the cabal version at 1.22 across the board since this preserves existing behavior. I would note however that https://github.com/hvr/multi-ghc-travis/blob/master/make_travis_yml.hs has a map of GHC version to the cabal version at the time (well, excepting anything before GHC 7.4/cabal 1.16, but that doesn't affect us) and usually tests the two together.

I don't have a strong opinion on what cabal version should be used, so I'll leave the existing behavior untouched unless there's a compelling reason to change.

@rbasso rbasso merged commit 214a7ef into exercism:master Jun 18, 2016
@petertseng petertseng deleted the travis-per-ghc branch June 18, 2016 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants