Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Tracking migration to hspec with fail-fast. #211

Closed
77 tasks done
rbasso opened this issue Jul 23, 2016 · 1 comment
Closed
77 tasks done

tests: Tracking migration to hspec with fail-fast. #211

rbasso opened this issue Jul 23, 2016 · 1 comment

Comments

@rbasso
Copy link
Contributor

rbasso commented Jul 23, 2016

Tracking migration to hspec with fail-fast

This issue is just for tracking. If you are interested in the discussion, please see #190.

Preparing
  • Create branch hspec-fail-fast
Migrating all exercises
  • Completely rewrite the test to use hspec with fail-fast.
  • Update test cases to match x-common, if needed.
  • Update package.yaml.
  • Merge PR to hspec-fail-fast master
Exercises
  • leap
  • accumulate
  • sublist
  • grains
  • gigasecond
  • bob
  • sum-of-multiples
  • strain
  • hamming
  • rna-transcription
  • space-age
  • anagram
  • phone-number
  • nucleotide-count
  • grade-school
  • simple-linked-list
  • list-ops
  • word-count
  • etl
  • robot-name
  • meetup
  • beer-song
  • triangle
  • scrabble-score
  • roman-numerals
  • binary
  • prime-factors
  • raindrops
  • allergies
  • atbash-cipher
  • all-your-base
  • bank-account
  • crypto-square
  • kindergarten-garden
  • robot-simulator
  • queen-attack
  • binary-search-tree
  • difference-of-squares
  • hexadecimal
  • largest-series-product
  • luhn
  • clock
  • matrix
  • house
  • minesweeper
  • ocr-numbers
  • octal
  • trinary
  • wordy
  • food-chain
  • linked-list
  • custom-set
  • nth-prime
  • palindrome-products
  • pascals-triangle
  • pig-latin
  • pythagorean-triplet
  • saddle-points
  • say
  • secret-handshake
  • series
  • sieve
  • simple-cipher
  • connect
  • parallel-letter-frequency
  • sgf-parsing
  • go-counting
  • zipper
  • forth
  • lens-person
  • pov
Testing
  • Clear Travis-CI cache.
  • Check if build and rebuild times are reasonable.
Merging and cleaning up
  • Merge hspec-fail-fast on master.
  • Delete branch hspec-fail-fast.
  • Clear Travis-CI cache and rebuild.

This accidentally fixes #263.
Closes #190.

This was referenced Jul 23, 2016
@rbasso
Copy link
Contributor Author

rbasso commented Oct 3, 2016

After 65 days and 71 PRs, we finally finished rewriting all exercises to use hspec.
Now every test suite will automatically stop on the first fail.

It's time to celebrate, @petertseng! 🎉 🍹 💃 🎊 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant