Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests.sh is not downloaded with executable permissions #76

Closed
tgecho opened this issue May 16, 2016 · 3 comments · Fixed by #96
Closed

runtests.sh is not downloaded with executable permissions #76

tgecho opened this issue May 16, 2016 · 3 comments · Fixed by #96

Comments

@tgecho
Copy link
Contributor

tgecho commented May 16, 2016

$ ./runtests.sh
-bash: ./runtests.sh: Permission denied

I didn't even think to check/ask, but it looks like this behavior was changed a few months ago: exercism/cli#276 :(

So... seeing as in my haste I've failed to create a clean/generic wrapper on the first try, I see a few obvious options:

  1. Remove the wrappers, switch the instructions back and wait for an updated elm-test to ship. elm-test MyTests.elm actually works right now, it just has a bunch of extraneous garbage at the end of the output.
  2. Update the instructions to bash runtests.sh.
  3. Write a node.js based wrapper (which could actually be cross platform) and instruct them to run node runtests.js.

Thoughts @parkerl @lukewestby?

@jwithington
Copy link

Also: if you're like me, you ended up here wondering why you couldn't run the tests.

This link helped me understand chown enough to get them running.

https://help.ubuntu.com/community/FilePermissions

@claytonflesher
Copy link

I'm willing to sit down this weekend and update the README for this track to walk newbies through how to make the .sh files executables for Linux and Mac users. I'm not sure what the appropriate way to describe running a .bat file in windows. Enter the filename from a cmd prompt?

@tgecho
Copy link
Contributor Author

tgecho commented Jul 15, 2016

@Calvyn82 thanks for reminding me about this! I'm really unhappy with asking people to modify the runtests scripts every time they download a new exercise.

I'm almost tempted to switch back to recommending elm-test-runner, with the caveat that it shows an odd error message at the end. It does look like rtfeldman is planning to update soon: https://github.com/rtfeldman/node-test-runner

$ elm-test SayTests.elm
Success! Compiled 1 module.
Successfully generated /var/folders/c8/lwxn19p55rj7mq0n7xhj0hv00000gp/T/elm_test_116615-34499-1gpd4jn.js
Successfully compiled SayTests.elm
Running tests...
  1 suites run, containing 17 tests
  All tests passed


: ""

[stdin]:7603
    if (typeof Elm === "undefined") { throw "elm-io config error: Elm is not defined. Make sure you call elm-io with a real Elm output file"}
                                      ^
elm-io config error: Elm is not defined. Make sure you call elm-io with a real Elm output file

If we want to stay self sufficient, I think I'd prefer to write a little node powered wrapper. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants