Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show minimal git clone output by default #60

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 19, 2020

PR #49 caused the program to produce no output during the git clone at the default verbosity setting. It was nice to remove the excessive git clone output, but total removal means that the program can appear to hang on a poor internet connection.

This commit makes the situation a little better for that case. In the future, we can try to improve the behaviour further.

Fixes: #52

Commit e5370b7 (exercism#49) caused the program to produce no output during
the `git clone` at the default verbosity setting. It was nice to remove
the excessive `git clone` output, but total removal means that the
program can appear to hang on a poor internet connection.

This commit makes the situation a little better for that case. In the
future, we can try to improve the behaviour further.

Fixes: exercism#52
@ee7 ee7 requested a review from ErikSchierboom as a code owner October 19, 2020 12:55
@ErikSchierboom ErikSchierboom merged commit 903f01c into exercism:master Oct 20, 2020
@ErikSchierboom
Copy link
Member

Thanks

@ee7 ee7 deleted the fix-git-clone-normal-verbosity branch October 20, 2020 11:13
ee7 added a commit to ee7/exercism-configlet that referenced this pull request Jan 21, 2021
Commit f502ab6 (exercism#49) caused the program to produce no output during
the `git clone` at the default verbosity setting. It was nice to remove
the excessive `git clone` output, but total removal means that the
program can appear to hang on a poor internet connection.

This commit makes the situation a little better for that case. In the
future, we can try to improve the behaviour further.

Fixes: exercism#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync: Seems to hang with slow/non-existant internet connection
2 participants