Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set kernelOptions for thebelab based on notebook's metadata #92

Merged
merged 2 commits into from
Jan 31, 2019
Merged

set kernelOptions for thebelab based on notebook's metadata #92

merged 2 commits into from
Jan 31, 2019

Conversation

joergbrech
Copy link
Contributor

fixes #90

@choldgraf
Copy link
Collaborator

really nice! thanks!

I made two quick changes to your branch:

  1. It's using nbformat now instead of JSON - I think this will make it a little bit more future-proof if the notebook format changes
  2. I added a test to make sure the kernel spec gets propagated.

If you're +1 on that commit, then I'm +1 on merge!

@joergbrech
Copy link
Contributor Author

Sounds good!

@choldgraf choldgraf merged commit af62928 into jupyter-book:master Jan 31, 2019
@choldgraf
Copy link
Collaborator

then let's merge away! 🎉 🎉 🎉

thanks for the patch!

@joergbrech joergbrech mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thebelab uses the wrong kernel
2 participants
@joergbrech @choldgraf