Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild file if source file has a newer time stamp #74

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Rebuild file if source file has a newer time stamp #74

merged 2 commits into from
Jan 9, 2019

Conversation

gaow
Copy link
Contributor

@gaow gaow commented Jan 8, 2019

I think we should build pages whose source is newer than that in _build folder. Here is a simple mechanism to achieve it.

@choldgraf
Copy link
Collaborator

This is a great idea! Thanks for the addition :-)

Do you think that you could throw in a quick test for this? E.g. add another test here

https://github.com/choldgraf/jupyter-book/blob/master/scripts/tests/test_build.py

that 1. Makes a modification to one of the content files in the test, 2. re-runs generate_book.py 3. Confirms that the modification propagated to the _build folder w/o needing to delete the file.

@gaow
Copy link
Contributor Author

gaow commented Jan 8, 2019

Sure, just added a test.

@choldgraf
Copy link
Collaborator

Beautiful - thanks for the patch :-) 🎉

@choldgraf choldgraf merged commit 64c5980 into jupyter-book:master Jan 9, 2019
choldgraf added a commit to choldgraf/jupyter-book that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants