Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: fixing jupytext install/UI links #737

Merged
merged 7 commits into from
Jul 22, 2020
Merged

Conversation

chrisjsewell
Copy link
Contributor

@chrisjsewell chrisjsewell commented Jun 27, 2020

maybe will fix #736?

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Jun 27, 2020

hmm I can't quite figure out how to test this, because https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?filepath=docs%2Fcontent%2Fexecute.md opens as jupter notebook not jupyter lab; why is that @choldgraf?

Anyway 5f50ee6 is definitely needed, but at least with jupyter notebook I still can't get it yet to open as myst markdown, rather than just jupytext markdown

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Jun 27, 2020

Ah yes thats working correctly now with https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?filepath=docs%2Fcontent%2Fexecute.md, but still need to test with jupyter lab some how

@chrisjsewell
Copy link
Contributor Author

ok I see how to open it as jupyter lab: https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?urlpath=lab%2Ftree%2Fdocs%2Fcontent%2Fexecute.md
Thats annoying that it doesn't open it by default with jupytext, like is done for jupyter notebook. Maybe there is some configuration that can achieve this?

@choldgraf
Copy link
Collaborator

Hey - just seeing this. I don't think it's possible to auto open markdown files as notebooks in lab, see

mwouts/jupytext#271

But, I didn't realize it was possible to do this with notebooks, so maybe in the meantime we just document this behavior and recommend people use the classic notebook interface for this use case?

@chrisjsewell
Copy link
Contributor Author

Haven’t read through that issue yet, but found this: jupyterlab/jupyterlab#6813, which maybe means it’s possible?

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Jun 27, 2020

ok yeh it doesn't seem possible yet with jupyter lab, looks like the postBuild is not needed also, it was just the missing myst-parser requirement that was the issue.

recommend people use the classic notebook interface for this use case?

Yeh I think that would be good, I see you can do that with: https://github.com/executablebooks/jupyter-book/blob/0326a41c653de8ff5f9f246e3ba808deed156797/docs/_config.yml#L28

should we change the setting in this repo also? and maybe make a new issue to track mwouts/jupytext#271, so we remember to change it back when, hopefully, that gets fixed

@choldgraf
Copy link
Collaborator

Yep that all sounds like a good idea to me 👍

@choldgraf
Copy link
Collaborator

do you want to change the interface for the jupyterbook docs / document this somewhere in this PR? Or in a different PR?

@chrisjsewell
Copy link
Contributor Author

do you want to change the interface for the jupyterbook docs / document this somewhere in this PR? Or in a different PR?

yep might as well do it here, will get round to it later in the week

@choldgraf
Copy link
Collaborator

heya - shall we just merge this in so that it doesn't become stale? WDYT?

@chrisjsewell chrisjsewell requested a review from choldgraf July 22, 2020 03:10
@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Jul 22, 2020

Ok I set the notebook interface to "classic" and made some refactoring to the launchbuttons.ipynb (see https://deploy-preview-737--jupyter-book.netlify.app/interactive/launchbuttons.html)

@choldgraf
Copy link
Collaborator

alright let's ship it! :shipit:

@choldgraf choldgraf changed the title install correct jupytext extension version 🐛 FIX: fixing jupytext install/UI links Jul 22, 2020
@choldgraf choldgraf merged commit 50f9b5a into master Jul 22, 2020
@choldgraf choldgraf deleted the mybinder-jupytext branch July 22, 2020 16:14
@choldgraf choldgraf added the bug Something isn't working label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Notebooks and Binder
2 participants