-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 FIX: fixing jupytext install/UI links #737
Conversation
hmm I can't quite figure out how to test this, because https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?filepath=docs%2Fcontent%2Fexecute.md opens as jupter notebook not jupyter lab; why is that @choldgraf? Anyway 5f50ee6 is definitely needed, but at least with jupyter notebook I still can't get it yet to open as myst markdown, rather than just jupytext markdown |
Ah yes thats working correctly now with https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?filepath=docs%2Fcontent%2Fexecute.md, but still need to test with jupyter lab some how |
ok I see how to open it as jupyter lab: https://mybinder.org/v2/gh/executablebooks/jupyter-book/mybinder-jupytext?urlpath=lab%2Ftree%2Fdocs%2Fcontent%2Fexecute.md |
Hey - just seeing this. I don't think it's possible to auto open markdown files as notebooks in lab, see But, I didn't realize it was possible to do this with notebooks, so maybe in the meantime we just document this behavior and recommend people use the classic notebook interface for this use case? |
Haven’t read through that issue yet, but found this: jupyterlab/jupyterlab#6813, which maybe means it’s possible? |
ok yeh it doesn't seem possible yet with jupyter lab, looks like the postBuild is not needed also, it was just the missing myst-parser requirement that was the issue.
Yeh I think that would be good, I see you can do that with: https://github.com/executablebooks/jupyter-book/blob/0326a41c653de8ff5f9f246e3ba808deed156797/docs/_config.yml#L28 should we change the setting in this repo also? and maybe make a new issue to track mwouts/jupytext#271, so we remember to change it back when, hopefully, that gets fixed |
Yep that all sounds like a good idea to me 👍 |
do you want to change the interface for the jupyterbook docs / document this somewhere in this PR? Or in a different PR? |
yep might as well do it here, will get round to it later in the week |
heya - shall we just merge this in so that it doesn't become stale? WDYT? |
Ok I set the notebook interface to "classic" and made some refactoring to the launchbuttons.ipynb (see https://deploy-preview-737--jupyter-book.netlify.app/interactive/launchbuttons.html) |
alright let's ship it! |
maybe will fix #736?