Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN: Jinja < 3.1 #1678

Merged
merged 2 commits into from
Mar 26, 2022
Merged

PIN: Jinja < 3.1 #1678

merged 2 commits into from
Mar 26, 2022

Conversation

choldgraf
Copy link
Collaborator

This pins Jinja < 3.1, so that we don't run into the bug described in:

closes #1676

@choldgraf
Copy link
Collaborator Author

Will merge this one if the tests are happy, because it'll un-break our failing tests

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1678 (be2eea8) into master (77961b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1678   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           7        7           
  Lines         690      690           
=======================================
  Hits          630      630           
  Misses         60       60           
Flag Coverage Δ
pytests 91.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77961b4...be2eea8. Read the comment docs.

@choldgraf choldgraf merged commit 5e12cb3 into master Mar 26, 2022
@choldgraf choldgraf deleted the pin-jinja branch March 26, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinja 3.1 is incompatible with Sphinx 3.5, and breaks Jupyter Book w/ this configuration
1 participant