Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary version constraint for click #1623

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Remove unnecessary version constraint for click #1623

merged 1 commit into from
Feb 8, 2022

Conversation

lukasbindreiter
Copy link
Contributor

As far as I can tell no click features are used that prevent an upgrade to v8 of click.

See #1590 for more info as to why this is necessary.

Related PR: executablebooks/sphinx-external-toc#69

@welcome
Copy link

welcome bot commented Feb 1, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me as long as all of the tests are happy!

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1623 (71ebdd5) into master (4e90fa1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           7        7           
  Lines         690      690           
=======================================
  Hits          630      630           
  Misses         60       60           
Flag Coverage Δ
pytests 91.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e90fa1...71ebdd5. Read the comment docs.

@choldgraf choldgraf merged commit 9ac546a into jupyter-book:master Feb 8, 2022
@welcome
Copy link

welcome bot commented Feb 8, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants