Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump sphinxcontrib-bibtex version #1513

Merged
merged 8 commits into from
Jan 1, 2022

Conversation

bryanwweber
Copy link
Contributor

Hello! I'm interested in using some new features from sphinxcontrib-bibtex, so I bumped the version locally and didn't have any problems. I also ran the test suite in the repo locally and didn't encounter any new errors from sphinxcontrib-bibtex.

I did run into an error with Pytest being pinned to such an old version, because I was using Python 3.10. So I bumped Pytest too.

Thanks!

bryanwweber and others added 4 commits October 15, 2021 16:03
setup.cfg doesn't have the "all" section anymore
This should enable Python 3.10 support
Remove the minor version compatibility requirement for
sphinxcontrib-bibtex. Jupyter Book seems to work with the newer versions
and there are new features that are nice.
@choldgraf
Copy link
Collaborator

I updated pytest in another PR so merged that change into here 👍

Looks like there are some failing tests, do you have a moment to figure out what's going on there?

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1513 (b19c75d) into master (8eca97d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1513   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files           7        7           
  Lines         686      686           
=======================================
  Hits          626      626           
  Misses         60       60           
Flag Coverage Δ
pytests 91.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eca97d...b19c75d. Read the comment docs.

@bryanwweber
Copy link
Contributor Author

@choldgraf I reverted the change I made to get the tests passing locally but I can't figure out why the tests are failing locally >_< I'll keep trying!

@bryanwweber
Copy link
Contributor Author

Ah, I think the tests are failing because I'm ending up with an .ipynb_checkpoints folder locally and maybe there isn't one on the test runner?

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tests are happy so I think we should merge it in. Sorry for the slow turnaround, it's been a busy few months!

@choldgraf choldgraf changed the title Bump sphinxcontrib-bibtex version MAINT: Bump sphinxcontrib-bibtex version Jan 1, 2022
@choldgraf choldgraf merged commit a17d43e into jupyter-book:master Jan 1, 2022
@bryanwweber bryanwweber deleted the sphinx-bibtex-version branch January 1, 2022 20:09
@bryanwweber
Copy link
Contributor Author

Thanks @choldgraf! Happy to see it merged 😁 Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants