-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Bump sphinxcontrib-bibtex version #1513
MAINT: Bump sphinxcontrib-bibtex version #1513
Conversation
setup.cfg doesn't have the "all" section anymore
This should enable Python 3.10 support
Remove the minor version compatibility requirement for sphinxcontrib-bibtex. Jupyter Book seems to work with the newer versions and there are new features that are nice.
I updated pytest in another PR so merged that change into here 👍 Looks like there are some failing tests, do you have a moment to figure out what's going on there? |
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 7 7
Lines 686 686
=======================================
Hits 626 626
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@choldgraf I reverted the change I made to get the tests passing locally but I can't figure out why the tests are failing locally >_< I'll keep trying! |
Ah, I think the tests are failing because I'm ending up with an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - tests are happy so I think we should merge it in. Sorry for the slow turnaround, it's been a busy few months!
Thanks @choldgraf! Happy to see it merged 😁 Happy holidays! |
Hello! I'm interested in using some new features from sphinxcontrib-bibtex, so I bumped the version locally and didn't have any problems. I also ran the test suite in the repo locally and didn't encounter any new errors from sphinxcontrib-bibtex.
I did run into an error with Pytest being pinned to such an old version, because I was using Python 3.10. So I bumped Pytest too.
Thanks!