-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make page_size configurable #25
Comments
We probably need to change this def initialize(attributes = {})
super(page_size: "LETTER") To: super(page_size: attributes.delete(:page_size) || "LETTER") |
haha, you're too reactive. i had hoped to twiddle together a nice naive pr :D |
It turns out that I already had this code on my laptop sitting in git staging from like a month ago and I just had to commit it. 😅 |
I'm sure there are lots of other improvements to be done, so PRs are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for this gem of a gem, it makes using prawn so much more reasonable.
is there a way to add page_size as a configurable?
as it is in the
initialize
function, i'm not sure how to override or configure it best. if you could give me some hints, i might be able to come up with a pr.The text was updated successfully, but these errors were encountered: