Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with http requests #480

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Fix issues with http requests #480

merged 3 commits into from
Sep 19, 2022

Conversation

sprmn
Copy link
Contributor

@sprmn sprmn commented Jun 30, 2022

Hi!

First of all, thank you for creating this awesome plugin.

I noticed two small issues while trying to work with the plugin for http requests:

  1. The port of the provided baseUrl is always overridden with 443.
  2. The request body is not added to POST requests.
  3. When the lambda@edge returns base64 it is not converted to text/json.

I fixed these in this PR. Hopefully you can merge it. Cheers!

@mattstrom
Copy link
Collaborator

Thanks for the contribution!

@mattstrom mattstrom merged commit 85c8921 into evolv-ai:master Sep 19, 2022
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
## [1.2.1](1.2.0...1.2.1) (2022-09-19)

### Bug Fixes

* fix issues with http requests ([#480](#480)) ([85c8921](85c8921))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants