Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline HTML #279

Closed
jkurei opened this issue Oct 17, 2016 · 5 comments
Closed

Inline HTML #279

jkurei opened this issue Oct 17, 2016 · 5 comments

Comments

@jkurei
Copy link

jkurei commented Oct 17, 2016

Gruber's Markdown supports embedded HTML tags inside Markdown (https://daringfireball.net/projects/markdown/syntax#html), but this library just shows the HTML as plain text.

I understand this may not be an easy feature to implement, or at least not safely, but since it is a feature in Gruber's specification, README.md should warn this is not supported.

Example, using the example code in README.md:

screen shot 2016-10-17 at 12 59 48

(I'm not sure that span to change the color should work, but even ignoring the styling the HTML tag should no appear; that table definitely should work)

@urosjarc
Copy link

This feature is a MUST.

@ashb
Copy link
Collaborator

ashb commented Nov 19, 2016

If someone writes this feature, and it has tests, and can be disabled in some manner then I'll happily merge it.

@sir-ragna
Copy link

Someone made a pull request for this. #98

@kpcyrd
Copy link

kpcyrd commented Jan 9, 2017

Please don't enable this by default, as you are probably introducing security issues for all your dependents if you do. 👎

html in markdown is nice if you're the only person using it, but a complete disaster for applications using markdown to render comments like github does. And, no, "safe html" is just asking for somebody to come up with a clever way to break it.

@ashb
Copy link
Collaborator

ashb commented Jan 9, 2017

Closing as duplicate of #98 where there's been more dicussion.

@ashb ashb closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants