Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maruku/meta/list tests fail #26

Open
kragen opened this issue Aug 2, 2011 · 3 comments
Open

Maruku/meta/list tests fail #26

kragen opened this issue Aug 2, 2011 · 3 comments
Labels

Comments

@kragen
Copy link

kragen commented Aug 2, 2011

edit: Ash renamed the bug to talk about the failure, not the error in the runner which is now fixed.

Checked out trunk (8b3cc2f) and with patr v0.2.6 and promised-io v0.2.3, I get the above. Modified the test to be more verbose, and in more detail:

AssertionError: Failed with error on /home/kragen/devel/markdown-js/test/features/meta/list.text: AssertionError: list; expected:
["html",
  ["ul",
    { "id" : "list" },
    ["li",
      "here's a\nloose list"
    ],
    ["li",
      "it might confuse the\nblock_meta routine"
    ]
  ]
]
got:
[
  "html",
  [
    "ul",
    [
      "li",
      [
        "p",
        "here's a\nloose list"
      ]
    ],
    [
      "li",
      [
        "p",
        "it might confuse the\nblock_meta routine\n{: #list}"
      ]
    ]
  ]
]

Despite the suggestion in the paragraph itself, the problem does not seem to be in Markdown.dialects.Maruku.block.block_meta; somehow, mysteriously, processBlock is not getting called for the last block, and so neither is block_meta.

@ashb
Copy link
Collaborator

ashb commented Aug 2, 2011

Hmmmm - ISTR that we left that in as a TODO without marking it as such.

Oh and feel free to use a different test library than patr (I just picked that as it needed the fewest changes).

@kragen
Copy link
Author

kragen commented Aug 3, 2011

I don't know enough about the current state of JS regression testing libraries to have anything I prefer to patr :)

@ashb
Copy link
Collaborator

ashb commented Apr 8, 2012

Switched over to node-tap and marked this test as a TODO.

Looking at the issue now. Its to do with how lists munge the next block without going through a full processBlock loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants