chore: lint driven refactoring

Author: evilsocket

src/agent/mod.rs

@@ -5,7 +5,7 @@ use mini_rag::Embedder;
 use serde::{Deserialize, Serialize};
 
 use events::Event;
-use generator::{Client, ChatOptions};
+use generator::{ChatOptions, Client};
 use namespaces::Action;
 use serialization::xml::serialize;
 use state::{SharedState, State};
@@ -82,7 +82,7 @@ impl Invocation {
             }
         }
 
-        return format!("{}({})", &self.action, parts.join(", "));
+        format!("{}({})", &self.action, parts.join(", "))
     }
 }
 
@@ -387,7 +387,7 @@ impl Agent {
 
                         let start = std::time::Instant::now();
                         let mut inp = "nope".to_string();
-                        while inp != "" && inp != "n" && inp != "y" {
+                        while !inp.is_empty() && inp != "n" && inp != "y" {
                             inp = cli::get_user_input(&format!(
                                 "{} [Yn] ",
                                 inv.as_function_call_string()

src/agent/namespaces/memory/mod.rs

@@ -93,6 +93,7 @@ impl Action for DeleteMemory {
     }
 }
 
+/*
 #[derive(Debug, Default, Clone)]
 struct RecallMemory {}
 
@@ -130,7 +131,7 @@ impl Action for RecallMemory {
         }
     }
 }
-
+ */
 pub(crate) fn get_namespace() -> Namespace {
     Namespace::new_default(
         "Memory".to_string(),

src/agent/serialization/xml/parsing.rs

@@ -58,7 +58,7 @@ fn preprocess_block(ptr: &str) -> String {
         // not a closing tag
         if ptr.as_bytes()[1] != b'/' {
             // determine tag name
-            let tag_name = &ptr[1..ptr.find(|c| c == ' ' || c == '>').unwrap()];
+            let tag_name = &ptr[1..ptr.find([' ', '>']).unwrap()];
             let payload_start_idx = ptr.find('>').unwrap();
             // if not a short <tag/>
             if !tag_name.ends_with('/') {